Bug 1479960
Summary: | grub2 symlink handling causing FAH ISO installer failures | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jonathan Lebon <jlebon> | ||||
Component: | grub2 | Assignee: | Peter Jones <pjones> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 27 | CC: | butirsky, dustymabe, lkundrak, miabbott, pjones | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | grub2-2.02-8.fc27 | Doc Type: | If docs needed, set a value | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2017-09-25 18:25:18 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Jonathan Lebon
2017-08-09 19:59:30 UTC
some notes from IRC: 15:17:28 dustymabe | hey pjones - got a sec? 15:17:53 pjones | dustymabe: how much of a second? 15:17:59 pjones | maybe, what's the issue? 15:18:08 dustymabe | https://bugzilla.redhat.com/show_bug.cgi?id=1479960 15:18:16 dustymabe | have you seen that by chance? 15:20:46 pjones | I hadn't, but I think I saw a patch that might fix it anyway 15:20:51 * | pjones looking now 15:20:55 dustymabe | thanks 15:21:24 dustymabe | if you want to make us a build we can get it tested 15:22:34 <-- | wcohen (wcohen@nat/redhat/x-okwxpxsjftrqcgvs) has quit (Ping timeout: 255 seconds) 15:22:35 <-- | pwhalen (~pwhalen@unaffiliated/pwhalen) has quit (Ping timeout: 255 seconds) 15:25:09 pjones | Oh, the thing I saw actually fixes a different (tangentially related) problem :/ 15:27:30 dustymabe | boo 15:30:03 pjones | dustymabe: so I don't really have time to hack on it right now, but if you want to give it a go, I suspect basically it's just | needing rename_target be the directory portion of "name" + "/" + rename_target instead, at | https://github.com/rhboot/grub2/blob/fedora-27/util/editenv.c#L95 15:30:55 dustymabe | pjones: quick question - do you think this affects just atomic host or other fedora types as well? 15:31:21 dustymabe | and when you say 'don't really have time to hack on it right now' do you mean today, this week, this month? 15:31:31 pjones | "until I've landed my f27 features" 15:32:14 pjones | well, probably anything that runs grub2-editenv from is affected, but there's not a lot that does that. 15:32:36 pjones | ... and not quite everything, because it depends on what CWD is when you invoke it 15:32:47 dustymabe | ok jlebon might be able to look at this on monday. Created attachment 1313303 [details]
Handle relative symlink targets
Tested working at least in the Fedora Atomic flow. This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle. Changing version to '27'. @pjones, what's the verdict on the patch? I believe this is resolved now. |