Bug 1480074
Summary: | Reduce dependencies for bodhi-client | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Lukas Slebodnik <lslebodn> |
Component: | bodhi | Assignee: | Randy Barlow <rbarlow> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | jeremy, lewk, randy, rbarlow |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | bodhi-3.6.0-1.fc29 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-04-18 15:50:03 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Lukas Slebodnik
2017-08-10 05:46:42 UTC
dnf has always been a requirement for the python bindings (and not for server purposes), it was just never declared and it was imported incorrectly. Also, in 2.10.0 it becomes a hard requirement: https://github.com/fedora-infra/bodhi/blob/ea115dc0fa09c09532165bfbf31d206cb72ee5a3/bodhi/client/bindings.py#L40 I do intend to port Bodhi to Python 3, but at the current time I have dependencies that are still Python 2 only and am about to gain one large new Python 2 dependency (pungi). (In reply to Randy Barlow from comment #1) > dnf has always been a requirement for the python bindings (and not for > server purposes), it was just never declared and it was imported > incorrectly. Also, in 2.10.0 it becomes a hard requirement: > I already mentioned that ticket description. You can see it in output of grep. Would you be so kind and could you explain how can I trigger code path which use dnf. Because I was not able to find where is method "testbable" used. So if There is not a way how to trigger that code patch from /usr/bin/bodhi then weak dependency make a sense. The bodhi-client package is not only for /usr/bin/bodhi - it is also Bodhi's Python bindings. Though the code in question is not used by /usr/bin/bodhi, it is a formally documented and supported feature of the Python bindings, which are intended to be used by third party libraries. The bindings are also how the /usr/bin/bodhi client works in general (and some bits of the server use them too). Thus, this is a real dependency. (In reply to Randy Barlow from comment #3) > The bodhi-client package is not only for /usr/bin/bodhi - it is also Bodhi's > Python bindings. Though the code in question is not used by /usr/bin/bodhi, > it is a formally documented and supported feature of the Python bindings, > which are intended to be used by third party libraries. The bindings are > also how the /usr/bin/bodhi client works in general (and some bits of the > server use them too). Thus, this is a real dependency. Even though I didn;t get direct answer to may question I infer that you confirmed that it is not possible to trigger that code path from /usr/bin/bodhi(bodhi-client) I understand that python bindings are not only for client and might be used also for other purposes. But main consumers of /usr/bin/bodhi are fedora package maintainers. Because it it more convenient to update package from command line then clicking in webUI. And I do not expect that pungi(+24 additional packages) will be used by package maintainers. This is a reason why title of this BZ is reduce dependencies for bodhi-client. There are more ways how to do it. (Use weak dependencies in python-bodhi, split python-bindigs into two packages, ...) That's decision for author. This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle. Changing version to '27'. bodhi-client 3.6.0 switched to python3. So dependency on python2-dnf is gone sh$ rpm -q --requires bodhi-client | grep dnf sh$ rpm -q --requires python3-bodhi | grep dnf sh$ rpm -q --requires python3-bodhi-client | grep dnf python3-dnf We can close this ticket Indeed, and thanks for the comment - I had forgotten to associate this ticket with the build. Note that only Rawhide uses Python 3 even though Fedora 28 also has bodhi-3.6.0, since it was a backwards incompatible change and was done relatively late in the Fedora 28 cycle. (In reply to Randy Barlow from comment #7) > Indeed, and thanks for the comment - I had forgotten to associate this > ticket with the build. Note that only Rawhide uses Python 3 even though > Fedora 28 also has bodhi-3.6.0, since it was a backwards incompatible change > and was done relatively late in the Fedora 28 cycle. That's fine I use rawhide :-) |