Bug 1480213

Summary: SSH public key field not shown when adding a host
Product: [oVirt] ovirt-engine Reporter: Fabrice Bacchella <fabrice.bacchella>
Component: GeneralAssignee: Scott Dickerson <sdickers>
Status: CLOSED CURRENTRELEASE QA Contact: samuel macko <smacko>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.1.3.5CC: bugs, fabrice.bacchella, gshereme, mperina, oourfali, pstehlik, sdickers
Target Milestone: ovirt-4.2.0Flags: rule-engine: ovirt-4.2+
sdickers: devel_ack+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-20 11:45:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: UX RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
On Safari
none
On Firefix
none
On Chrome none

Description Fabrice Bacchella 2017-08-10 12:18:54 UTC
Created attachment 1311728 [details]
On Safari

Only chrome can show the root ssh public key when configuring the root authentication of a new host.

Comment 1 Fabrice Bacchella 2017-08-10 12:19:22 UTC
Created attachment 1311729 [details]
On Firefix

Comment 2 Fabrice Bacchella 2017-08-10 12:19:43 UTC
Created attachment 1311731 [details]
On Chrome

Comment 3 Oved Ourfali 2017-08-29 12:27:11 UTC
Ravi, can you please take a look?

Comment 4 Martin Perina 2017-08-30 11:15:34 UTC
I'm not able to reproduce this issue with latest oVirt 4.1.6 RC1 build. I've tested Firefox 52.3.0 and Chrome 60.0.3112.113 and on both browsers the SSH Public Key field is displayed properly.

Could you please try to clear your cache and check again? If it doesn't help, could you please try to upgrade engine to latest 4.1.z version?

Comment 5 Fabrice Bacchella 2017-08-31 16:29:41 UTC
This bug is here from at least 3.6. So I don't think it's a clean cache problem. But I'm on mac os, it might be related. But it's still strange that it shows on FF too.

Comment 6 Pavel Stehlik 2017-10-24 10:24:09 UTC
Indeed: 4.1.7

<div class="form-group" title="For allowing PK authentication, copy the following PK to host under /root/.ssh/authorized_keys" style="visibility: hidden"><label class="control-label labelEnabled" for="HostPopupView_publicKey" style="display: none;" aria-hidden="true"></label><div><div class="GKIIXFICK-B"><textarea style="border-width: 0px;" id="HostPopupView_publicKey" class="form-control form-control-readonly" readonly="" tabindex="15"></textarea></div></div><div class="GKIIXFICH-B"></div></div>

note the "hidden" - once I removed it, it's shown. 

Chrome probably doesn't respect that element, thus is only which shows it.
(Safari nor FF 55.0.3 - don't show).

Comment 7 Martin Perina 2017-10-24 10:27:20 UTC
Greg, could someone from UX team a look, why this issue exists on MacOS? As it works fine on Linux as mentioned in Comment 4

Comment 8 Scott Dickerson 2017-10-24 15:59:59 UTC
The visibility style on the form-group holding the ssh public key field wasn't being changed when the radio buttons were clicked, but only in Safari.  Patch addresses 2 potential issues:
   1. directly changing the style vs standard #setVisibility()
   2. change from onFocus to onClick for the event handlers on the 
      password and ssh public key radio buttons

Comment 9 samuel macko 2017-12-08 12:09:27 UTC
Verified in RHVM version 4.2.0-0.6.el7 on Firefox 57.0.

Verified by following the reproducer.

Comment 10 Sandro Bonazzola 2017-12-20 11:45:36 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.