Bug 1480667

Summary:	openshift-supported drupal quickstart fails to deploy
Product:	OpenShift Online	Reporter:	Sten Turpin <sten>
Component:	Templates	Assignee:	Abhishek Gupta <abhgupta>
Status:	VERIFIED ---	QA Contact:	Gaoyun Pei <gpei>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	2.x	CC:	aos-bugs, bparees, rthrashe, xiuwang, xtian
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sten Turpin 2017-08-11 16:36:56 UTC

Description of problem: The openshift-maintained Drupal cartridge fails to deploy. There's a patch operation that no longer applies as scripted in the cartridge. 


Version-Release number of selected component (if applicable): HEAD of https://github.com/openshift/drupal-quickstart


How reproducible: Always


Steps to Reproduce:
1. Deploy a new app from https://github.com/openshift/drupal-quickstart


Actual results:
The initial build for the application failed: Shell command '/sbin/runuser
-s /bin/sh 597eebba2d5271f7d2000065 -c "exec /usr/bin/runcon
'unconfined_u:system_r:openshift_t:s0:c6,c204' /bin/sh -c \"gear
postreceive --init >> /tmp/initial-build.log 2>&1\""' returned an error.
rc=255
 
.Last 10 kB of build output:
Stopping PHP 5.4 cartridge (Apache+mod_php)
Stopping MySQL 5.5 cartridge
Stopping Cron cartridge
Repairing links for 1 deployments
Building git ref 'master', commit edccbed
Checking .openshift/pear.txt for PEAR dependency...
Checking composer.json for Composer dependency...
Warning: This development build of composer is over 30 days old. It is
recommended to update it by running
"/var/lib/openshift/597eebba2d5271f7d2000065/php/usr/bin/composer
self-update" to get the latest version.
Loading composer repositories with package information
Installing dependencies (including require-dev)
- Installing symfony/yaml (v2.8.25)
Downloading
 
- Installing symfony/polyfill-mbstring (v1.4.0)
Downloading
 
- Installing symfony/var-dumper (v2.8.25)
Downloading
 
- Installing psr/log (1.0.2)
Downloading
 
- Installing pear/console_table (v1.2.1)
Downloading
 
- Installing d11wtq/boris (v1.0.10)
Downloading
 
- Installing drush/drush (7.4.0)
Downloading
 
symfony/var-dumper suggests installing ext-symfony_debug ()
pear/console_table suggests installing pear/Console_Color2 (>=0.1.2)
Writing lock file
Generating optimized autoload files
 
Download and install the latest stable version of Drupal
 
Project drupal (7.56) downloaded to
[success]
/var/lib/openshift/597eebba2d5271f7d2000065/app-root/data/downloads/drupal-7.56.
Project drupal contains:
[success]
- 3 profiles: testing, standard, minimal
- 4 themes: stark, seven, garland, bartik
- 47 modules: drupal_system_listing_incompatible_test,
drupal_system_listing_compatible_test, user, update, trigger,
translation, tracker, toolbar, taxonomy, system, syslog, statistics,
simpletest, shortcut, search, rdf, profile, poll, php, path, overlay,
openid, node, menu, locale, image, help, forum, filter, file,
field_ui, text, options, number, list, field_sql_storage, field,
dblog, dashboard, contextual, contact, comment, color, book, blog,
block, aggregator
 
patching file
/var/lib/openshift/597eebba2d5271f7d2000065/app-root/data/downloads/drupal-7.56/.htaccess
Hunk #1 FAILED at 4.
1 out of 1 hunk FAILED -- saving rejects to file
/var/lib/openshift/597eebba2d5271f7d2000065/app-root/data/downloads/drupal-7.56/.htaccess.rej
An error occurred executing 'gear postreceive' (exit code: 1)
Error message: CLIENT_ERROR: Failed to execute action hook 'build' for
597eebba2d5271f7d2000065 application drupal

Expected results:
App should deploy 

Additional info:

Comment 1 Rory Thrasher 2017-08-11 22:02:21 UTC

From a very quick look, the patch for .htaccess in the drupal quickstart github is for drupal 7.43 and openshift is now using 7.56.  The patch file may no longer be needed as drupal 7.56 has its own conditional to check for the apache 2.4 issue.  Removing the patch works for me in online, though I didn't test with different versions of apache.

I opened a PR to remove the patch here: https://github.com/openshift-quickstart/drupal-quickstart/pull/42

Customers who want to use the drupal quickstart in the meantime are welcome to update the source code link on the drupal quickstart to `https://github.com/thrasher-redhat/drupal-quickstart.git` with the branch `htaccess-fix`.  Alternatively, customers can remove this line <https://github.com/openshift-quickstart/drupal-quickstart/blob/master/.openshift/action_hooks/build#L63> in their own fork and use that as the source.

More info:
Drupal 7.56 patchnotes which mention .htaccess changes - https://secure.installatron.com/updatefeed/drupal_7_56
Drupal 7.56 .htaccess - https://github.com/drupal/drupal/blob/7.56/.htaccess

Comment 2 XiuJuan Wang 2017-08-22 03:18:20 UTC

Could deploy quickstart with https://github.com/openshift/drupal-quickstart in openshift.redhat.com.