Bug 1480795

Description of problem:
ecryptfs-mount-private and ecryptfs-umount-private both increment/decrement /dev/shm/ecryptfs-$USER-Private even if they fail

Version-Release number of selected component (if applicable):
ecryptfs-utils-111-2.fc25.x86_64

How reproducible:
When ecryptfs-mount-private fails because passphrase signature is not on root's keyring (see bug #1480793)

Steps to Reproduce:
1. try to mount ~/.Private if mount passphrase is not on root's keyring
2.
3.

Actual results:
mount operation fails, and /dev/shm/ecryptfs-$USER-Private is incremented

Expected results:
Since the operation failed, /dev/shm/ecryptfs-$USER-Private should not be incremented. Now, trying to umount ~/.Private gives an error:

~ ecryptfs-umount-private 
Sessions still open, not unmounting

Additional info:
The error is cumulative: the more I run ecryptfs-mount-private, the more the counter is incremented. On the other hand, ecryptfs-umount-private also decrements the counter even if it fails:

~ ecryptfs-mount-private 
Enter your login passphrase:
Inserted auth tok with sig [XXX] into the user session keyring
mount: No such file or directory

~ cat /dev/shm/ecryptfs-costa-Private 
1

~ ecryptfs-mount-private 
Enter your login passphrase:
Inserted auth tok with sig [XXX] into the user session keyring
mount: No such file or directory

~ cat /dev/shm/ecryptfs-costa-Private 
3

~ ecryptfs-umount-private 
Sessions still open, not unmounting
~ cat /dev/shm/ecryptfs-costa-Private 
2

~ ecryptfs-umount-private 
Sessions still open, not unmounting
~ cat /dev/shm/ecryptfs-costa-Private 
1

~ ecryptfs-umount-private 

~ cat /dev/shm/ecryptfs-costa-Private 
0

~ ecryptfs-umount-private 

~ cat /dev/shm/ecryptfs-costa-Private 
0