Bug 1480973 (golang-github-alecthomas-kingpin)
| Summary: | Review Request: golang-github-alecthomas-kingpin - A Go command line and flag parser | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | sensor.wen |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | athoscribeiro, eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-07-22 13:32:07 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1465889, 1421046, 1476589, 1476590 | ||
|
Description
sensor.wen
2017-08-13 09:13:30 UTC
Hello,
- The _examples/ folder should go in %doc:
%doc _examples
And remove it from devel.file-list:
for file in $(find . -iname "*.go" \! -iname "*_test.go" \! -path "./_examples/*") ; do
- Change:
%dir %{gopath}/src/%{import_path}
to
%dir %{gopath}/src/%{import_path}/cmd
And remove: %{gopath}/src/%{import_path2}
(The import_path was already listed but the subdirectory cmd was not)
- Missing dependency:
DEBUG util.py:450: No matching package to install: 'golang(github.com/alecthomas/assert)'
→ Bug #1480971: accepted but not yet built. It seems you haven't yet requested the repo to be created with fedrepo-req. Please do it so we can move forward.
Diff: https://github.com/FZUG/repo/commit/bba881590a66a510dbf653210ac5b23c96f0da0e Fixed. the github-alecthomas-assert package is build passed, but it is not included in the rawhide. Maybe we need to wait some time. https://src.fedoraproject.org/rpms/golang-github-alecthomas-assert This is okay for me, package accepted. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-kingpin Should this be closed? This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort. |