Bug 1481199

Summary:	mempool: run-time crash when built with --disable-mempool
Product:	[Community] GlusterFS	Reporter:	Milind Changire <mchangir>
Component:	core	Assignee:	Milind Changire <mchangir>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, nbalacha
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.13.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-08 17:38:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Milind Changire 2017-08-14 11:01:53 UTC

Description of problem:
mempool: run-time crash when built with --disable-mempool

Version-Release number of selected component (if applicable):
mainline

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-08-14 11:09:21 UTC

REVIEW: https://review.gluster.org/18034 (mempool: fix code when GF_DISABLE_MEMPOOL is defined) posted (#1) for review on master by Milind Changire (mchangir)

Comment 2 Worker Ant 2017-08-21 12:28:49 UTC

REVIEW: https://review.gluster.org/18034 (mempool: fix code when GF_DISABLE_MEMPOOL is defined) posted (#2) for review on master by Niels de Vos (ndevos)

Comment 3 Worker Ant 2017-08-21 13:22:30 UTC

REVIEW: https://review.gluster.org/18034 (mempool: fix code when GF_DISABLE_MEMPOOL is defined) posted (#3) for review on master by Niels de Vos (ndevos)

Comment 4 Worker Ant 2017-08-22 10:46:52 UTC

REVIEW: https://review.gluster.org/18034 (mempool: fix code when GF_DISABLE_MEMPOOL is defined) posted (#4) for review on master by Niels de Vos (ndevos)

Comment 5 Worker Ant 2017-08-30 15:32:33 UTC

REVIEW: https://review.gluster.org/18034 (mempool: fix code when GF_DISABLE_MEMPOOL is defined) posted (#5) for review on master by Niels de Vos (ndevos)

Comment 6 Worker Ant 2017-09-02 02:21:20 UTC

COMMIT: https://review.gluster.org/18034 committed in master by Jeff Darcy (jeff.us) 
------
commit 3737ed53caad69ddb0f5b3db2e3498c2d7df2dff
Author: Niels de Vos <ndevos>
Date:   Fri Aug 18 17:12:05 2017 +0200

    mempool: fix code when GF_DISABLE_MEMPOOL is defined
    
    Problem: Run-time crash is observed when attempting to memset() a zero
    length buffer.
    
    Solution: When GF_DISABLE_MEMPOOL is set, mem_get() gets translated to a
    GF_MALLOC(). The size of the allocation does not need to relate to the
    available (but uninitialized) global memory pools. It is fine to
    allocate the exact amount of memory that was configured when the
    mem-pool was created.
    
    Change-Id: Iea0bff974bb771623a34d7a940e10cb0db0f90e1
    BUG: 1481199
    Reported-by: Milind Changire <mchangir>
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: https://review.gluster.org/18034
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jeff.us>

Comment 7 Shyamsundar 2017-12-08 17:38:25 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/