Bug 1481637

Summary: Inconsistency between filled name and name in accordion of Provision Dialogs
Product: Red Hat CloudForms Management Engine Reporter: Yadnyawalk Tale <ytale>
Component: UI - OPSAssignee: Greg Piatigorski <gpiatigo>
Status: CLOSED CURRENTRELEASE QA Contact: Yadnyawalk Tale <ytale>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.9.0Flags: ytale: automate_bug-
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui:automate:dialog
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1512694 (view as bug list) Environment:
Last Closed: 2018-03-06 14:36:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1512694    
Attachments:
Description Flags
working_names none

Description Yadnyawalk Tale 2017-08-15 09:34:04 UTC 
Description of problem:
Inconsistency between filled dialog name and added dialog name in accordion of Provision Dialogs

Version-Release number of selected component:
5.8.1.5.20170725160636_e433fc0

How reproducible:
100% (Always)

Steps to Reproduce:
1. Navigate to Automation -> Automate -> Customization
2. Add new dialog there (Put name as 'dialog_name' and 'description as dialog_desc'

Actual results:
Showing dialog_desc as a added dialog name in accordion

Expected results:
Should display dialog_name instead of dialog_desc

Additional info: 
Linked with github issue -> https://github.com/ManageIQ/manageiq/issues/15742
Comment 4 Greg Piatigorski 2017-08-28 18:46:21 UTC 
NOTE: 
Code refactored to display dialog Add/Save/Cancel (edit) confirmation messages with Dialog Descriptions (to match other UI areas for consistency).

Leaving accordion tree node to display dialog descriptions, rather than names, due to dialog names possibly being too short/cut off and not be descriptive enough as tree node for quick navigation.
Comment 5 CFME Bot 2017-08-28 20:13:48 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/2027
Comment 6 CFME Bot 2017-09-20 16:53:51 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/a20a4b927840bf4391df93e6bf49b09a8edfa9ed

commit a20a4b927840bf4391df93e6bf49b09a8edfa9ed
Author:     Greg Piatigorski <gpiatigo>
AuthorDate: Mon Aug 28 12:57:11 2017 -0700
Commit:     Greg Piatigorski <gpiatigo>
CommitDate: Mon Aug 28 13:19:17 2017 -0700

    Fix custom Provisioning dialogs confirmation flash messages
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1481637

 app/controllers/miq_ae_customization_controller/old_dialogs.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 8 Yadnyawalk Tale 2017-11-27 06:44:01 UTC 
Created attachment 1359302 [details]
working_names

Hey,

Showing 'desc' added as well as deleted, working fine with this fix!
Verified on: 5.9.0.10.20171121225911_a2209d2 

Thanks!