Bug 1481682

Summary:	Review Request: platform-python - A Python interpreter for basic system tools
Product:	[Fedora] Fedora	Reporter:	Tomas Orsava <torsava>
Component:	Package Review	Assignee:	Stephen Gallagher <sgallagh>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mhroncok, package-review, sgallagh, torsava
Target Milestone:	---	Flags:	sgallagh: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	platform-python-3.6.2-11.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-17 06:07:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1479272

Description Tomas Orsava 2017-08-15 12:46:50 UTC

Spec URL: https://github.com/fedora-python/python3/blob/platform_python/platform-python.spec

SRPM URL: https://github.com/torsava/python3-1/blob/platform_python_srpm/platform-python-3.6.2-10.fc27.src.rpm?raw=true

Patches and other files: https://github.com/fedora-python/python3/tree/platform_python

Description: Python interpreter for low-level system tools, designed to work with the Platform module.

Fedora Account System Username: torsava

===========================================================

This is a modification of the existing `python3` package. It is designed for the [Modularity] initiative to be part of the Platform module, specifically to enable dnf.

The lengths of the Python spec files are commensurate with the important role they serve, and thus we provide the [diff] between the proposed platform-python and the existing python3 package to serve as a better reviewing tool than the totality of the spec.

[Modularity] https://docs.pagure.org/modularity/
[diff] https://github.com/fedora-python/python3/pull/3

Comment 1 Miro Hrončok 2017-08-15 12:57:17 UTC

I have checked the diff and it looks good to me (this is not a formal review).

Comment 2 Tomas Orsava 2017-08-15 12:59:48 UTC

Here is the corresponding Fedora Change: https://fedoraproject.org/wiki/Changes/Platform_Python_Stack

Comment 3 Stephen Gallagher 2017-08-15 19:02:28 UTC

Spec URL: https://github.com/fedora-python/python3/blob/platform_python/platform-python.spec?raw=true

SRPM URL: https://github.com/torsava/python3-1/blob/platform_python_srpm/platform-python-3.6.2-10.fc27.src.rpm?raw=true


Adding 'raw=true' to the URL so `fedora-review` will work.

Comment 4 Stephen Gallagher 2017-08-15 19:05:12 UTC

Spec URL: https://raw.githubusercontent.com/fedora-python/python3/platform_python/platform-python.spec

SRPM URL: https://raw.githubusercontent.com/torsava/python3-1/platform_python_srpm/platform-python-3.6.2-10.fc27.src.rpm

Apparently fedora-review drops the arguments. So here's the paths to the actual raw content.

Comment 5 Stephen Gallagher 2017-08-15 19:19:46 UTC

OK, I reviewed this by inspection (because fedora-review can't handle it). In brief: things look fine to me, all licenses and legalities appear to be in order and the diff from the python3 package looks completely sane.

I'm comfortable approving this.

Comment 6 Gwyn Ciesla 2017-08-15 21:30:12 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/platform-python

Comment 7 Gwyn Ciesla 2017-08-15 21:30:25 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/platform-python

Comment 8 Miro Hrončok 2017-08-16 07:47:12 UTC

Cannot push to dist-git

https://pagure.io/fedora-infrastructure/issue/6260

Comment 9 Miro Hrončok 2017-08-16 09:27:46 UTC

Solved. Building in https://koji.fedoraproject.org/koji/taskinfo?taskID=21258874

Comment 10 Tomas Orsava 2017-08-16 13:18:41 UTC

Thank you, Stephen, for a prompt review!