Bug 1481870

Summary: Quota not using cloud volumes in requested resource calculation.
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: AutomateAssignee: William Fitzgerald <wfitzger>
Status: CLOSED ERRATA QA Contact: Aziza Karol <akarol>
Severity: medium Docs Contact:
Priority: high    
Version: 5.7.0CC: akarol, cpelland, dajohnso, jhardy, mkanoor, obarenbo, simaishi, tfitzger, wfitzger
Target Milestone: GAKeywords: ZStream
Target Release: 5.7.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: quota:cloud:volume
Fixed In Version: 5.7.4.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1455349 Environment:
Last Closed: 2017-12-18 20:29:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1455349    
Bug Blocks:    

Comment 2 CFME Bot 2017-08-15 22:36:06 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/34e190196e43b5085ec88a44db9a74d7ac434198

commit 34e190196e43b5085ec88a44db9a74d7ac434198
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Mon Aug 14 14:29:03 2017 -0400
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Aug 15 18:29:58 2017 -0400

    Merge pull request #138 from billfitzgerald0120/quota_cloud_volumes
    
    Added cloud volumes to requested resource calculation.
    (cherry picked from commit 70a6dedc2c10062d7817d2867fa9635fe6c43f34)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1481870

 .../QuotaMethods.class/__methods__/requested.rb             | 13 +++++++++++++
 .../unit/method_validation/calculate_requested_spec.rb      | 11 +++++++++++
 2 files changed, 24 insertions(+)

Comment 5 William Fitzgerald 2017-10-05 23:57:31 UTC
Aziza,

See comment above

Comment 6 Aziza Karol 2017-10-06 10:05:03 UTC
Hi William,

I updated the dialog by removing Number_of_vms and Flavors/instances and tried provisioning. I get the quota exceeded messages and the quota calculations are correct but when i updated the same catalog item by changing the volume from 8GB to 1GB and provisioned, the quota calculations seems to be wrong and this needs to fixed.

Ex:
1.When you provision using services catalogs with volume :8 GB, number of instances:2 flavor: m1.tiny the quota calculation message 
shows "Request exceeds maximum allowed for the following: (storage - Used: 29 GB plus requested: 18 GB exceeds quota: 30.5 GB).

2.Update the same catalog item from 8GB to 1GB and provision,it shows the same quota calculations which is wrong. The new quota  exceeded message should be "Request exceeds maximum allowed for the following: (storage - Used: 29 GB plus requested: 4 GB exceeds quota: 30.5 GB)".

Can you please check on same appliance?

Thanks,
Aziza

Comment 7 Aziza Karol 2017-10-06 10:37:11 UTC
Billy,

For point 2 in comment 4 i have open a separate bz https://bugzilla.redhat.com/show_bug.cgi?id=1499193 for tracking the Flavors/instances in a dialog.


Thanks,
Aziza

Comment 8 William Fitzgerald 2017-10-06 13:28:23 UTC
Aziza, 

Thanks for opening the separate bz for flavors.

What Service catalog are you uaing ?

Please let me know.

Thanks

Billy

Comment 9 Aziza Karol 2017-10-06 15:25:44 UTC
Billy,

I am using "testvolume" service catalog.


Thanks,
Aziza

Comment 10 William Fitzgerald 2017-10-10 17:49:33 UTC
Aziza,

 I tested on your appliance.  When I create a service item with a cloud volume, it appears to work.  When I edit the service item and change the cloud volume,
the service item still uses the original cloud volume which is wrong.

I have opened a separate BZ for this problem:

 https://bugzilla.redhat.com/show_bug.cgi?id=1500486

Can you please test again without changing the cloud volume.  Maybe create one service item with 1 gig and another service item with 8 gig.

Please let me know if you have any questions.

Thanks

Billy

Comment 11 Aziza Karol 2017-10-13 11:05:50 UTC
Hey Billy,

Thanks for logging that Bz.

I tested  two service item with 1 gig and another service item with 8 gig. Seems to work well. Getting the quota denial messages.

~Aziza

Comment 13 Aziza Karol 2017-11-16 06:25:08 UTC
The remaining issues are covered in the following BZs so moving it to verified.

https://bugzilla.redhat.com/show_bug.cgi?id=1500486
https://bugzilla.redhat.com/show_bug.cgi?id=1499193
https://bugzilla.redhat.com/show_bug.cgi?id=1497912

Comment 16 errata-xmlrpc 2017-12-18 20:29:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3484