Bug 1481986

Summary:	Review Request: python-consul - Python client for Consul (http://www.consul.io/)
Product:	[Fedora] Fedora	Reporter:	Yatin Karel <ykarel>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	karlthered, mail, package-review, ppisar, zebob.m
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-11 00:47:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449, 1427510

Description Yatin Karel 2017-08-16 08:34:49 UTC

Spec URL: https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-consul.spec
SRPM URL: https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-consul-0.7.1-1.fc25.src.rpm
Description: Python client for Consul.io
Fedora Account System Username: ykarel


Koji scratch builds:-
f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=21258510
f25: https://koji.fedoraproject.org/koji/taskinfo?taskID=21258459

Comment 1 Haïkel Guémar 2017-08-17 10:48:00 UTC

This line is likely a typo?
> requirements.txt

You shouldn't need to duplicate sources

No need to list all files in %files, I'd also list treq as a required dependency for twisted support (not mandatory to have it packaged for initial review though)

Comment 2 Yatin Karel 2017-08-23 08:56:46 UTC

Incorporated comments, Updated Spec File and SRPM:-

Spec URL: https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-consul.spec
SRPM URL: https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-consul-0.7.1-1.fc25.src.rpm


Koji build successful: https://koji.fedoraproject.org/koji/taskinfo?taskID=21417553

Comment 3 Yatin Karel 2017-09-06 10:06:54 UTC

python-treq is available in testing now, so updated the spec to use it:-

Spec URL: https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-consul.spec
SRPM URL: https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-consul-0.7.1-1.fc27.src.rpm


Koji Build Successful: https://koji.fedoraproject.org/koji/taskinfo?taskID=21678759

Comment 4 Fabian Affolter 2019-05-30 08:58:28 UTC

The latest release is 1.1.0

Comment 5 Haïkel Guémar 2019-07-26 07:12:46 UTC

Unassigning as I'm not working on this.

Comment 6 Robert-André Mauchin 🐧 2019-07-26 16:56:59 UTC

(In reply to Yatin Karel from comment #3)
> python-treq is available in testing now, so updated the spec to use it:-
> 
> Spec URL:
> https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-
> consul.spec
> SRPM URL:
> https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-
> consul-0.7.1-1.fc27.src.rpm
> 
> 
> Koji Build Successful:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=21678759

Still need a review on this? If yes please update and i'll review.

Comment 7 Package Review 2020-07-11 00:47:34 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.