Bug 1482095

Summary:	Review Request: arduino-listSerialPortsC - Simple multiplatform program to list serial ports with vid/pid/iserial fields
Product:	[Fedora] Fedora	Reporter:	Tom "spot" Callaway <tcallawa>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-11-24 06:41:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tom "spot" Callaway 2017-08-16 12:52:10 UTC

Spec URL: https://spot.fedorapeople.org/arduino-1.8/arduino-listSerialPortsC.spec
SRPM URL: https://spot.fedorapeople.org/arduino-1.8/arduino-listSerialPortsC-1.4.0-1.fc26.src.rpm
Description: Simple environment to test libserialport in a single build machine fashion.
Fedora Account System Username: spot
Copr Build: https://copr.fedorainfracloud.org/coprs/spot/arduino-1.8/package/arduino-listSerialPortsC/

Note: This is a new dependency needed to upgrade to Arduino 1.8.

Comment 1 Neal Gompa 2017-08-16 12:59:57 UTC

Taking this review.

Comment 2 Neal Gompa 2017-08-16 13:31:28 UTC

Review notes:

* Package is named correctly
* Package builds and installs correctly
* Package follows general packaging guidelines correctly
* rpmlint produced errors

rpmlint errors:
arduino-listSerialPortsC.x86_64: E: arch-dependent-file-in-usr-share /usr/share/arduino/lib/liblistSerialsj.so

This is as intended, so I'm going to ignore it.


Issues to fix on import:
* Changelog entry has the wrong version reference

Otherwise, looks good. Please fix the changelog entry on import.

PACKAGE APPROVED.

Comment 3 Gwyn Ciesla 2017-08-17 13:38:28 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/arduino-listSerialPortsC

Comment 4 Gwyn Ciesla 2017-08-17 13:38:37 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/arduino-listSerialPortsC

Comment 5 Fedora Update System 2017-09-01 11:50:35 UTC

arduino-1.8.4-1.fc26, arduino-builder-1.3.25-1.fc26, arduino-listSerialPortsC-1.4.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f0a69429bd