Bug 1483308
| Summary: | Review Request: pgzero - A zero-boilerplate 2D games framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lumír Balhar <lbalhar> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zebob.m |
| Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-31 22:51:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Lumír Balhar
2017-08-20 10:43:51 UTC
Hello, - I think you should add the "examples/" to the %doc. - You should add a more meaningful name to the downloaded archive, with: Source0: https://bitbucket.org/lordmauve/%{name}/get/%{version}.tar.gz#/%{name}-%{version}.tar.gz - We've got several license here, you must add them all in the License: tag and detail which covers what part. *No copyright* Apache (v2.0) ---------------------------- lordmauve-pgzero-de127c76f809/examples/basic/fonts/Cherry_Cream_Soda/LICENSE.txt lordmauve-pgzero-de127c76f809/examples/basic/fonts/Roboto_Condensed/LICENSE.txt *No copyright* CC by-sa (v4.0) ------------------------------ lordmauve-pgzero-de127c76f809/examples/lander/lander.py CC0 --- lordmauve-pgzero-de127c76f809/examples/basic/fonts/bubblegum_sans.ttf LGPL (v3) -------- lordmauve-pgzero-de127c76f809/COPYING MIT/X11 (BSD like) ------------------ lordmauve-pgzero-de127c76f809/examples/memory/LICENCE SIL (v1.1) ---------- lordmauve-pgzero-de127c76f809/examples/basic/fonts/Boogaloo/OFL.txt lordmauve-pgzero-de127c76f809/examples/basic/fonts/Bubblegum_Sans/OFL.txt See https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses for a list of valid license shortname. For example SIL license shortname is OFL and Apache → ASL 2.0. Thank you very much for the review and mentioned points. All of them are fixed in the newest version of specfile and srpm available at the same links. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21380419 This won't work: License: LGPLv3, ASL 2.0, CC-BY-SA, CC0, MIT, OFL Licenses must be separated by "and". Also you need to specify in a comment which license covers what part, e.g. bubblegum_sans.ttf under CC0 and so on. Fixed. Is it now ok? Thank you. Yes thank you, package accepted. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/pgzero pgzero-1.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a6119d4d5d pgzero-1.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a6119d4d5d pgzero-1.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |