Bug 1483519

Summary: [RFE] Verification of shared storage configuration values is missing.
Product: Red Hat Enterprise Virtualization Manager Reporter: Nikolai Sednev <nsednev>
Component: ovirt-hosted-engine-setupAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED DEFERRED QA Contact: Nikolai Sednev <nsednev>
Severity: low Docs Contact:
Priority: low    
Version: 4.1.5CC: dfediuck, lsurette, mavital, ykaul, ylavi
Target Milestone: ovirt-4.3.0Keywords: FutureFeature
Target Release: ---Flags: mavital: testing_plan_complete?
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-03 13:09:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Nikolai Sednev 2017-08-21 10:38:23 UTC
Description of problem:
Verification of shared storage configuration values is missing.
Customer can provide any alphanumeric values as an input for shared storage configuration values with no verification. For example "gateway" key value like "nfs3" is accepted.

# hosted-engine --set-shared-config gateway nfs3 --type he_conf
# hosted-engine --get-shared-config gateway --type he_conf
gateway : nfs3, type : he_conf


Version-Release number of selected component (if applicable):
ovirt-hosted-engine-ha-2.1.5-1.el7ev.noarch
ovirt-hosted-engine-setup-2.1.3.6-1.el7ev.noarch

How reproducible:
100%

Steps to Reproduce:
1.Try setting and getting any improper key value to any possible he_conf key value, e.g. hosted-engine --set-shared-config port nfs3 --type he_conf.

Actual results:
There is no input verification exists for he_conf input key values.
# hosted-engine --set-shared-config port nfs3 --type he_conf
# hosted-engine --get-shared-config port --type he_conf
port : nfs3, type : he_conf


Expected results:
Each key value should be verified prior to being accepted and if unacceptable value provided, warning message should be provided for customer. 

Additional info:
Please see this pastebin for more technical details http://pastebin.test.redhat.com/509814.

Comment 1 Sandro Bonazzola 2017-10-20 05:48:30 UTC
Will be solved with node zero deployment flow