Bug 1483795

Summary: Crashes when nl-cache is enabled
Product: [Community] GlusterFS Reporter: Zhang Huan <zhhuan>
Component: coreAssignee: bugs <bugs>
Status: CLOSED NOTABUG QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: mainlineCC: amukherj, bugs, pgurusid
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-22 06:21:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Zhang Huan 2017-08-22 01:39:11 UTC
Description of problem:
When nl-cache is enabled, glusterfs crash while activating graph.

Version-Release number of selected component (if applicable):


How reproducible:
Every time

Steps to Reproduce:
1. enable nl-cache
2. run glusterfs
3.

Actual results:
glusterfs client crash

Expected results:
glusterfs run without error

Additional info:
This problem is in glusterfs_ctx_tw_get(). When ctx->tw is initialized to call glusterfs_ctx_tw_get, will call GF_REF_GET to add refcount and return the existing ctx->tw pointer. However, return of GF_REF_GET is an integer of ref counter, but incorrectly use as pointer to return.

Comment 1 Zhang Huan 2017-08-22 02:47:21 UTC
I don't have permission to submit it to gerrit. Signing in with GitHub account gave me a result of "forbidden". Thus I put my fix here FYI.

https://github.com/zhanghuan/glusterfs-1/commit/edd98bd8bf5b2efe1cd067028096eef9ed585dc6

Comment 2 Atin Mukherjee 2017-08-22 05:13:54 UTC
Poornima - Could you have a look at the patch provided by Zhang and port it in gerrit?

Comment 3 Zhang Huan 2017-08-22 06:03:56 UTC
Oops, it is my mistake that this is NOT an issue in master. Sorry for the inconvenience. I will close it.

Comment 4 Red Hat Bugzilla 2023-09-14 04:02:46 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days