Bug 1483998 (rhel81-crypto-policies-libssh)

Summary: libssh client: follow the policies of system-wide crypto policy
Product: [Fedora] Fedora Reporter: Nikos Mavrogiannopoulos <nmavrogi>
Component: libsshAssignee: Anderson Sasaki <ansasaki>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ansasaki, asn, negativo17, rdieter
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libssh-0.9.0-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1610883 (view as bug list) Environment:
Last Closed: 2019-06-28 09:48:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1179209, 1610883, 1635111    
Attachments:
Description Flags
Support include files none

Description Nikos Mavrogiannopoulos 2017-08-22 12:43:56 UTC 
Please utilize the system's crypto policy for enabled by default ciphers:
https://fedoraproject.org/wiki/Packaging:CryptoPolicies

As it is now libssh's configuration is provided per application using ssh_options_parse_config() making the administrator/user responsible any enabled ciphers, and in case of software upgrades to keep up-to-date the list of available ciphers allowed, parameters etc.

It would align more to the fedora system-wide policy directions if the library could apply some default settings based on the system policy when the user doesn't override/set a config file. For example fallback into reading a global configuration file in case the user doesn't have one (e.g., /etc/crypto-policies/back-ends/openssh.config).
Comment 1 Nikos Mavrogiannopoulos 2017-08-24 11:26:29 UTC 
It seems the code already falls back to read /etc/ssh/ssh_config when no filename is set, or no user config exists. However, in Fedora we use Include directives on the configuration file, which in turn include /etc/ssh/ssh_config.d/05-redhat.conf and this includes /etc/crypto-policies/back-ends/openssh.config.

So this is pretty much an RFE to support recursive including of files.
Comment 2 Nikos Mavrogiannopoulos 2017-08-24 13:50:57 UTC 
Created attachment 1317699 [details]
Support include files