Bug 1484164
| Summary: | Review Request: libsocketpp - C++ Standard I/O TCP sockets | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Charlie Sale <chucks.8090> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED DEFERRED | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora, jwakely, ngompa13, package-review, rdieter |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-09-13 14:39:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 177841 | ||
|
Description
Charlie Sale
2017-08-22 23:00:47 UTC
>Group: Development/Tools The "Group:" tag should not be used. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections >License: GPL+ "GPL+" should only be used when upstream doesn't specify the licence version. You're using GPL v3 or later, so the tag should be "GPLv3+". https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses Thanks. I'll get that fixed up. Quick question: because this is a development library, should I add the suffix "-devel" to my package or not? don't rename it, it's fine as-is Ok. Thanks! Well, actually, the package spec needs to be reorganized and the package does need to be slightly renamed... Here's a relatively simple example of how a library package looks: https://src.fedoraproject.org/rpms/libbluray/blob/master/f/libbluray.spec Thanks. I'll get that fixed and uploaded very soon. Are any of you able to formally review my package or sponsor me? That would be really helpful... Everything is up to date. Note, the URLS from above need to be updated. Here they are: Spec: https://raw.githubusercontent.com/softwaresale/libsocketpp_rpm_build_files/master/libsocketpp.spec SRPM: https://raw.githubusercontent.com/softwaresale/libsocketpp_rpm_build_files/master/libsocketpp-1.0.0-1.fc26.src.rpm I can sponsor, and I'll take the review. Thanks a ton Neal. Let me know if you have any questions for me regarding sponsorship. My email is <chucks.8090> Hey Neal. Can I have an update on the review process of my package? Is there anything I can fix for you? > %autosetup -n %{name}-%{version} This is redundant, just use "%autosetup", as "-n %{name}-%{version}" is the default > make %{?_smp_mflags} Use %make_build > rm -f $RPM_BUILD_ROOT/%{_infodir}/dir > rm -f $RPM_BUILD_ROOT/%{_libdir}/libsocketpp.la Use %{buildroot} instead of $RPM_BUILD_ROOT > ldconfig Use "/sbin/ldconfig" > %postun > ldconfig Use "%postun -p /sbin/ldconfig" > %global gittag0 v1.0.0 This is unnecessary, as %{version} is already defined at 1.0.0 > Source0: https://github.com/softwaresale/%{name}/archive/%{gittag0}/%{name}-%{version}.tar.gz Change usage of "%{gittag0}" to "v%{version}". This lets you control the version bump from a single location. Hey Neal I am actually retracting my submission due to C++20 releasing a networking library, which makes libsocketpp redundant and therefore unnecessary. Thanks for your time anyways! This code leaks memory and doesn't close sockets. Fedora already has a number of mature C++ libraries providing similar functionality (boost-asio, asio, poco-net, ...) so I don't see why we would want this anyway. |