Bug 1484337
| Summary: | Refresh fails: undefined method `[]' for nil:NilClass in `parse_image_name' | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Beni Paskin-Cherniavsky <cben> | |
| Component: | Providers | Assignee: | Adam Grare <agrare> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | juwatts | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 5.7.0 | CC: | agrare, cben, efreiber, fsimonce, gblomqui, jfrey, jhardy, obarenbo, simaishi | |
| Target Milestone: | GA | Keywords: | TestOnly | |
| Target Release: | 5.9.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | container | |||
| Fixed In Version: | 5.9.0.1 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1487280 1487283 (view as bug list) | Environment: | ||
| Last Closed: | 2018-03-06 14:50:15 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | Container Management | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1487280, 1487283 | |||
|
Description
Beni Paskin-Cherniavsky
2017-08-23 09:44:43 UTC
Beni I assigned this to Erez because he worked with images, if you think that this is a more generic issue in the refresher feel free to take it. https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/94 is a proposed workaround that would let refresh complete and log what we failed on. This BZ reminds me of https://bugzilla.redhat.com/show_bug.cgi?id=1449278 where some fields that we assumed will always be are not present. I think this is a similar case. New commit detected on ManageIQ/manageiq-providers-kubernetes/master: https://github.com/ManageIQ/manageiq-providers-kubernetes/commit/22f8ab0e1716c6871239486a76ffef8ebf2e1c5e commit 22f8ab0e1716c6871239486a76ffef8ebf2e1c5e Author: Adam Grare <agrare> AuthorDate: Tue Aug 15 17:00:56 2017 -0400 Commit: Adam Grare <agrare> CommitDate: Fri Aug 25 12:56:41 2017 -0400 Skip invalid container_images https://bugzilla.redhat.com/show_bug.cgi?id=1484337 .../kubernetes/container_manager/refresh_parser.rb | 25 ++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) To be clear, this did not solve the root cause, there is still input our refresh parser doesn't understand. We don't yet know what that input looks like. That "skip invalid container images" commit merely lets rest of refresh complete when that happens, and logs the offending input. Great point Beni, I think the bug here is that refresh fails with undefined method `[]' for nil:NilClass but once we figure out the cause there should be another BZ to handle whatever name was causing this parsing error. Verified on version: 5.9.0.11.20171127204214_e316988 Verification Steps: 1) Add an OpenShift provider to CFME appliance 2) On the OpenShift provider, created a pod json file and changed the "image" key value from a valid image to "bad-Image-name" 3) Saved and created the pod 4) On the CFME appliance, ran a manual refresh 5) Verified the refresh was successful and the above ERROR was not logged |