Bug 1484398

Summary: [3.4] Metrics and Logging deployer templates should use v3.x
Product: OpenShift Container Platform Reporter: Ruben Romero Montes <rromerom>
Component: InstallerAssignee: Scott Dodson <sdodson>
Installer sub component: openshift-ansible QA Contact: Johnny Liu <jialiu>
Status: CLOSED ERRATA Docs Contact:
Severity: low    
Priority: unspecified CC: aos-bugs, jokerman, mmccomas, sdodson, smunilla, wsun
Version: 3.4.1   
Target Milestone: ---   
Target Release: 3.4.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
The metrics deployer template has been updated to point at images labeled v3.4 which ensures that the latest builds are deployed.
Story Points: ---
Clone Of:
: 1484403 (view as bug list) Environment:
Last Closed: 2017-09-05 17:42:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1484403    

Description Ruben Romero Montes 2017-08-23 12:52:47 UTC
Description of problem:
Users always have to provide the IMAGE_VERSION=3.4.1 param when running the deployer or else they will get the latest 3.4.0 version instead of the 3.4.1 version.

Version-Release number of selected component (if applicable):
OpenShift 3.3.x
OpenShift 3.4.x

How reproducible:
Always

Steps to Reproduce:
1. Install Metrics using the deployer
 $ oc new-app logging-deployer-template

Actual results:
$ oc exec logging-es-ja0vy5bi-1-8c9v6 -- ls -la /root/buildinfo
Dockerfile-openshift3-logging-elasticsearch-3.3.0-11

Expected results:
$ oc exec logging-es-ja0vy5bi-1-8c9v6 -- ls -la /root/buildinfo
Dockerfile-openshift3-logging-elasticsearch-3.3.1-17

Additional info:

Comment 1 Ruben Romero Montes 2017-08-23 12:54:51 UTC
The example is with the logging-deployer instead of the Metrics but the result is the same.

Users need to run the deployer like so:
$ oc new-app logging-deployer-template --param IMAGE_VERSION=3.4.1

Comment 4 Junqi Zhao 2017-08-28 07:48:24 UTC
@Scott

When I tried to pull logging-curator:3.4.1 from brew registry, I found the latest image version is 3.4.1-20, which is not the latest version actually.

openshift3/logging-curator         3.4.1               fa1520d5c994        8 weeks ago         244.5 MB
openshift3/logging-curator         3.4.1-20            fa1520d5c994        8 weeks ago         244.5 MB

Then I tried to pull logging-curator: v3.4 from brew registry, I found the latest image version is v3.4.1.44.17-1, it is the correct latest version.

openshift3/logging-curator         v3.4                f69156734b7c        2 days ago          248.2 MB
openshift3/logging-curator         v3.4.1.44.17-1      f69156734b7c        2 days ago          248.2 MB

Does it mean we could only use v3.4 tag to pull the latest images, 3.4.1 image tag won't pointed to the latest 3.4 images?

Same concerns with 3.3.1 images

Comment 5 Scott Dodson 2017-08-28 12:46:42 UTC
They're all the same on registry.access.redhat.com. I'd assume any discrepancy on the internal registry is just a side effect of build automation.

[root@ose3-master ~]# docker images | grep logging-curator                                                                                        
registry.access.redhat.com/openshift3/logging-curator       3.4.1               fa1520d5c994        8 weeks ago         244.5 MB
registry.access.redhat.com/openshift3/logging-curator       v3.4                fa1520d5c994        8 weeks ago         244.5 MB
registry.access.redhat.com/openshift3/logging-curator       3.3.1               9b0a85bf33e9        10 weeks ago        245 MB
registry.access.redhat.com/openshift3/logging-curator       v3.3                9b0a85bf33e9        10 weeks ago        245 MB

Comment 6 Junqi Zhao 2017-08-29 00:34:54 UTC
we could find openshift-ansible-3.4.130-1**** and openshift-ansible-3.4.132-1*** in puddle server, but can not find openshift-ansible-3.4.131-1.git.0.50210f9.el7 in puddle server, will verify it after we get the build.

Comment 7 Junqi Zhao 2017-08-29 02:03:03 UTC
(In reply to Scott Dodson from comment #5)
> They're all the same on registry.access.redhat.com. I'd assume any
> discrepancy on the internal registry is just a side effect of build
> automation.

Could you help to solve the issue I mentioned in Comment 4, or should I ask for someone else?

for logging 3.3 and 3.4 images, only logging-curator has this issue, other images don't have such issue.

Comment 8 Scott Dodson 2017-08-29 19:51:04 UTC
Junqi,

I've rebuilt the puddles. There's been a newer build of openshift-ansible-3.4 but we don't intend to ship that so we'll need to use the 'errata' puddles.

3.4 puddle 

http://download-node-02.eng.bos.redhat.com/rcm-guest/puddles/RHAOS/AtomicOpenShift-errata/3.4/latest/RH7-RHAOS-3.4/x86_64/os/

3.3 puddle

http://download-node-02.eng.bos.redhat.com/rcm-guest/puddles/RHAOS/AtomicOpenShift-errata/3.3/latest/RH7-RHAOS-3.3/x86_64/os/Packages/

Comment 9 Scott Dodson 2017-08-29 19:54:37 UTC
Sam,

Can you help Junqi sort out their questions in comment 7 and 4?

Comment 10 Junqi Zhao 2017-08-30 08:07:57 UTC
Used build openshift-ansible-3.4.131-1.git.0.50210f9.el7 from https://errata.devel.redhat.com/advisory/29863 to build env, deployed metrics and logging with v3.4 image tag, we could get the latest 3.4.1 images, and they passed our sanity testing.

Used brew registry,take logging-fluentd for example, the image vesion is logging-fluentd-3.4.1-26
# oc exec logging-fluentd-xpibt -- ls -al /root/buildinfo
total 8
drwxr-xr-x. 2 root root   91 Aug 29 17:16 .
dr-xr-x---. 3 root root  154 Jul 25 18:00 ..
-rw-r--r--. 1 root root 2072 Aug 29 17:14 Dockerfile-openshift3-logging-fluentd-3.4.1-26
-rw-r--r--. 1 root root 2708 Jul 25 17:59 Dockerfile-rhel7-7.4-81


logging-fluentd-3.4.1-26 is the currently latest image, logging-fluentd-3.4.1-26 and logging-fluentd:v3.4 are the same image
openshift3/logging-fluentd            3.4.1-26            47f0abe0b613        10 hours ago        235.9 MB
openshift3/logging-fluentd            v3.4                47f0abe0b613        10 hours ago        235.9 MB


# openshift version
# openshift version
openshift v3.4.1.44.17
kubernetes v1.4.0+776c994
etcd 3.1.0-rc.0

Comment 11 Junqi Zhao 2017-08-30 08:09:18 UTC
Sam,

Please continue to help to solve the issue I mentioned in Comment 7 and 4.

Thanks

Comment 13 errata-xmlrpc 2017-09-05 17:42:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2639