Bug 1484490

Summary:	File-level WORM allows mv over read-only files
Product:	[Community] GlusterFS	Reporter:	Lucas Ferreira <luneo7>
Component:	unclassified	Assignee:	Lucas Ferreira <luneo7>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, ksubrahm
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:	worm
Fixed In Version:	glusterfs-3.13.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1480788	Environment:
Last Closed:	2017-12-08 17:39:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lucas Ferreira 2017-08-23 17:46:40 UTC

+++ This bug was initially created as a clone of Bug #1480788 +++

Description of problem:

It is possible to move one recently created file over a read only file, overwriting it.

Version-Release number of selected component (if applicable):

3.10 and 3.11

How reproducible:


Steps to Reproduce:

1. create a worm volume file level
$ gluster volume create v1 replica 3 172.17.0.{2,3,4}:/mnt/v1 force
$ gluster volume set v1 features.read-only "off"
$ gluster volume set v1 features.worm "off"
$ gluster volume set v1 features.worm-file-level "on"
$ gluster volume set v1 features.retention-mode relax
$ gluster volume set v1 features.auto-commit-period 20
$ gluster volume set v1 features.default-retention-period 600
$ gluster volume start v1
$ mount -t glusterfs 172.17.0.2:/v1 /home/lucas/storage

Volume Name: v1
Type: Replicate
Volume ID: 72a968d9-9aaa-4cde-9954-4e5a91065abf
Status: Started
Snapshot Count: 0
Number of Bricks: 1 x 3 = 3
Transport-type: tcp
Bricks:
Brick1: 172.17.0.2:/mnt/v1
Brick2: 172.17.0.3:/mnt/v1
Brick3: 172.17.0.4:/mnt/v1
Options Reconfigured:
features.default-retention-period: 600
features.auto-commit-period: 20
features.retention-mode: relax
features.worm-file-level: on
features.worm: off
features.read-only: off
transport.address-family: inet
nfs.disable: on

2. create file on WORM volume (File Level)
$ cd /home/lucas/storage
$ echo "Hello World" > testfile

3. wait for the auto commit time and try to delete it
$ rm testfile
rm: cannot remove 'testfile': Read-only file system

4. create a new file and do a mv command to overwrite the existing file
$ echo "Aloha" > testfile2
$ mv testfile2 testfile

Actual results:

- The mv command executes successfully and overwrites the read only file.

Expected results:

- The mv command should fail, giving some error regarding a read only file.

Additional info:

Comment 1 Worker Ant 2017-08-23 18:27:20 UTC

REVIEW: https://review.gluster.org/18104 (features/worm: Adding check to newloc when doing rename) posted (#1) for review on master by Anonymous Coward

Comment 2 Worker Ant 2017-08-24 11:51:22 UTC

REVIEW: https://review.gluster.org/18104 (features/worm: Adding check to newloc when doing rename) posted (#2) for review on master by Lucas Ferreira (luneo7)

Comment 3 Worker Ant 2017-08-25 19:03:19 UTC

REVIEW: https://review.gluster.org/18104 (features/worm: Adding check to newloc when doing rename) posted (#3) for review on master by Shyamsundar Ranganathan (srangana)

Comment 4 Worker Ant 2017-09-01 13:13:50 UTC

REVIEW: https://review.gluster.org/18104 (features/worm: Adding check to newloc when doing rename) posted (#4) for review on master by Lucas Ferreira (luneo7)

Comment 5 Worker Ant 2017-09-06 12:07:30 UTC

REVIEW: https://review.gluster.org/18104 (features/worm: Adding check to newloc when doing rename) posted (#5) for review on master by Lucas Ferreira (luneo7)

Comment 6 Worker Ant 2017-09-12 06:15:00 UTC

REVIEW: https://review.gluster.org/18104 (features/worm: Adding check to newloc when doing rename) posted (#6) for review on master by Prashanth Pai (ppai)

Comment 7 Worker Ant 2017-09-18 07:15:03 UTC

COMMIT: https://review.gluster.org/18104 committed in master by Amar Tumballi (amarts) 
------
commit 00a4dc058a0573d18e9c1bd3692fecee151a9285
Author: luneo7 <luneo7>
Date:   Wed Aug 23 15:25:57 2017 -0300

    features/worm: Adding check to newloc when doing rename
    
    Problem: Since rename didn't check if newloc exists and it's
    retention state it was possible to rename a new file that wasn't
    in retention over a existing file that was in read-only state.
    
    Change-Id: I63c6bbabb7bb456ebedf201cc77b878ffda62229
    BUG: 1484490
    Signed-off-by: luneo7 <luneo7>
    Reviewed-on: https://review.gluster.org/18104
    Tested-by: jiffin tony Thottan <jthottan>
    Tested-by: Prashanth Pai <ppai>
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Prashanth Pai <ppai>
    Reviewed-by: Karthik U S <ksubrahm>
    Reviewed-by: Amar Tumballi <amarts>

Comment 8 Shyamsundar 2017-12-08 17:39:07 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/