Bug 1485793

Summary:	[RFE] Add default display resolution xres and yres for qxl and virtio gpu
Product:	[Community] Virtualization Tools	Reporter:	Han Han <hhan>
Component:	libvirt	Assignee:	yafu <yafu>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	berrange, dyuan, fjin, jcfaracco, libvirt-maint, xuzhang
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-12-17 12:22:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Han Han 2017-08-28 06:13:45 UTC

Description of problem:
This feature is from qemu:
virtio-gpu: add xres and yres properties:
https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg01769.html

qxl: add xres and yres properties:
http://lists.gnu.org/archive/html/qemu-devel/2017-04/msg04158.html

After this feature realized, the xml should be like:
<video>
      <model type='qxl' ram='65536' vram='65536' vgamem='16384' heads='1' primary='yes' xres='' yres=''/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
    </video>

Comment 1 Han Han 2019-10-18 06:16:21 UTC

POST by:
https://www.redhat.com/archives/libvir-list/2019-October/msg01052.html

Comment 2 Julio Faracco 2019-10-19 04:33:15 UTC

It was included into upstream by:

commit 7286279797a34b3083d85bc4556432b5e7ad9fff
Author:     Julio Faracco <jcfaracco>
AuthorDate: Thu Oct 17 01:30:31 2019 -0300
Commit:     Cole Robinson <crobinso>
CommitDate: Thu Oct 17 16:18:34 2019 -0400

    conf: Add 'x' and 'y' resolution into video XML definition
    
    This commit adds resolution element with parameters 'x' and 'y' into video
    XML domain group definition. Both, properties were added into an element
    called 'resolution' and it was added inside 'model' element. They are set
    as optional. This element does not follow QEMU properties 'xres' and
    'yres' format. Both HTML documentation and schema were changed too. This
    commit includes a simple test case to cover resolution for QEMU video
    models. The new XML format for resolution looks like:
    
        <model ...>
          <resolution x='800' y='600'/>
        </model>
    
    Reviewed-by: Cole Robinson <crobinso>
    Signed-off-by: Julio Faracco <jcfaracco>

Comment 3 Daniel Berrangé 2024-12-17 12:22:14 UTC

Closing on the basis that the last comment indicates the fix was committed