Bug 1486110

Summary:	[quorum]: Replace brick is happened when Quorum not met.
Product:	[Community] GlusterFS	Reporter:	Gaurav Yadav <gyadav>
Component:	glusterd	Assignee:	Gaurav Yadav <gyadav>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.12	CC:	amukherj, bsrirama, bugs, nlevinki, pasik, rhs-bugs, sbairagy, storage-qa-internal, vbellur
Target Milestone:	---	Keywords:	ZStream
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.12.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1483058	Environment:
Last Closed:	2017-09-05 17:40:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1262230, 1483058
Bug Blocks:

Description Gaurav Yadav 2017-08-29 04:35:13 UTC

+++ This bug was initially created as a clone of Bug #1483058 +++

+++ This bug was initially created as a clone of Bug #1262230 +++

Description of problem:
Brick replace is happened successfully when Quorum not met also which is not expected.

How reproducible:
Always

Steps to Reproduce:
1.Create a cluster of two nodes (Node-1 and Node-2)
2.Create a Distributed volume using two node bricks.
3.Start the Volume.
4.Shutdown one of the node (Node-2)
5. 
  a. Check the volume status //brick status should be offline (To make sure Quorum Not met )
    (OR)
  b. Check for message "Server quorum lost for volume Dis. Stopping local bricks." in /var/log/messages

6. Replace the existing brick on node which is up with new brick.


Actual results:
Replace brick is happened when quorum not met


Expected results:
Replace brick should not happen when quorum not met.

--- Additional comment from Worker Ant on 2017-08-18 13:46:11 EDT ---

REVIEW: https://review.gluster.org/18068 (glusterd: replace-brick executing successfully when quorum does not met) posted (#1) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-08-21 01:02:16 EDT ---

REVIEW: https://review.gluster.org/18068 (glusterd: replace-brick executing successfully when quorum does not met) posted (#2) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-08-21 05:10:16 EDT ---

REVIEW: https://review.gluster.org/18068 (glusterd: replace-brick executing successfully when quorum does not met) posted (#3) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-08-21 05:27:44 EDT ---

REVIEW: https://review.gluster.org/18068 (glusterd: replace-brick executing successfully when quorum does not met) posted (#4) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-08-21 05:52:28 EDT ---

REVIEW: https://review.gluster.org/18068 (glusterd: replace-brick executing successfully when quorum does not met) posted (#5) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-08-22 06:09:09 EDT ---

REVIEW: https://review.gluster.org/18068 (glusterd: replace-brick executing successfully when quorum does not met) posted (#6) for review on master by Gaurav Yadav (gyadav)

--- Additional comment from Worker Ant on 2017-08-22 11:54:41 EDT ---

COMMIT: https://review.gluster.org/18068 committed in master by Atin Mukherjee (amukherj) 
------
commit 5f3ff9b33c286b30f2c6d2fadf53757b9f48859e
Author: Gaurav Yadav <gyadav>
Date:   Fri Aug 18 23:06:13 2017 +0530

    glusterd: replace-brick executing successfully when quorum does not met
    
    Problem:
    replace-brick command on a setup where quorum does not met executing
    successfully.
    
    Fix:
    With the fix glusterd is validating whether server is in quorum or not
    during replace-brick staging
    
    Change-Id: I8017154bb62bdcc6c6490e720ecfe9cde090c161
    BUG: 1483058
    Signed-off-by: Gaurav Yadav <gyadav>
    Reviewed-on: https://review.gluster.org/18068
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 1 Worker Ant 2017-08-29 04:38:11 UTC

REVIEW: https://review.gluster.org/18125 (glusterd: replace-brick executing successfully when quorum does not met) posted (#1) for review on release-3.12 by Gaurav Yadav (gyadav)

Comment 2 Worker Ant 2017-08-29 12:39:57 UTC

COMMIT: https://review.gluster.org/18125 committed in release-3.12 by Shyamsundar Ranganathan (srangana) 
------
commit 7e89bcd213fd69dd6da7cdb1ec0699e7b8a547d5
Author: Gaurav Yadav <gyadav>
Date:   Fri Aug 18 23:06:13 2017 +0530

    glusterd: replace-brick executing successfully when quorum does not met
    
    Problem:
    replace-brick command on a setup where quorum does not met executing
    successfully.
    
    Fix:
    With the fix glusterd is validating whether server is in quorum or not
    during replace-brick staging
    
    >Reviewed-on: https://review.gluster.org/18068
    >Smoke: Gluster Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Reviewed-by: Atin Mukherjee <amukherj>
    
    Change-Id: I8017154bb62bdcc6c6490e720ecfe9cde090c161
    BUG: 1486110
    Signed-off-by: Gaurav Yadav <gyadav>
    Reviewed-on: https://review.gluster.org/18125
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Prashanth Pai <ppai>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Shyamsundar 2017-09-05 17:40:02 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/