Bug 1486197

Summary: Should remove --dcpath text in the error message
Product: Red Hat Enterprise Linux 7 Reporter: kuwei <kuwei>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: unspecified    
Version: 7.4CC: juzhou, mxie, mzhan, ptoscano, rjones, tzheng, xiaodwan
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: V2V
Fixed In Version: libguestfs-1.36.6-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 09:18:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description kuwei@redhat.com 2017-08-29 08:06:54 UTC 
Description of problem:
Should remove  --dcpath text in the error message 

Version-Release number of selected component (if applicable):
virt-v2v-1.36.3-6.el7_4.3.x86_64
libvirt-3.2.0-14.el7_4.3.x86_64
qemu-kvm-rhev-2.9.0-16.el7_4.5.x86_64
libguestfs-1.36.3-6.el7_4.3.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Prepare a guest with snapshot on vmware and using virt-v2v to convert the guest to libvirt.
# virt-v2v -ic vpx://root.75.182/data/10.73.3.19/?no_verify=1 -o rhev -os 10.73.131.93:/home/nfs_export -of raw -b ovirtmgmt -n ovirtmgmt Auto-esx5.5-rhel7.1-snapshot  --password-file /tmp/passwd
[   0.0] Opening the source -i libvirt -ic vpx://root.75.182/data/10.73.3.19/?no_verify=1 Auto-esx5.5-rhel7.1-snapshot
'curl' -q --max-redirs '5' --globoff --head --silent --url 'https://10.73.75.182/folder/Auto-esx5.5-rhel7.1-snapshot/Auto-esx5.5-rhel7.1-snapshot-000001-flat.vmdk?dcPath=data&dsName=ESX5.5-auto' --user <hidden> --insecure
HTTP/1.1 404 Not Found
Date: Mon, 28 Aug 2017 08:18:05 GMT
Set-Cookie: vmware_soap_session="f84a5fadec143b93898247195a6e14fbc133bd08"; Path=/; HttpOnly; Secure; 
Connection: close
Content-Type: text; charset=plain
Content-Length: 0

virt-v2v: error: vcenter: URL not found: 
https://10.73.75.182/folder/Auto-esx5.5-rhel7.1-snapshot/Auto-esx5.5-rhel7.1-snapshot-000001-flat.vmdk?dcPath=data&dsName=ESX5.5-auto

The '--dcpath' parameter may be useful.  See the explanation in the 
virt-v2v(1) man page OPTIONS section.

If reporting bugs, run virt-v2v with debugging enabled and include the 
complete output:

  virt-v2v -v -x [...]

2.We can see some error message about "--dcpath", but the option "dcpath" has removed from man page,so we should remove  --dcpath text in the error message .

Actual results:
As above

Expected results:
should remove  --dcpath text in the error message

Additional info:
Comment 2 Richard W.M. Jones 2017-08-29 08:13:55 UTC 
Simple downstream-only modification of this error message:

https://github.com/libguestfs/libguestfs/blob/rhel-7.5/v2v/vCenter.ml#L102
Comment 3 Pino Toscano 2017-08-29 10:22:31 UTC 
Yup, easy enough.
Comment 5 mxie@redhat.com 2017-09-19 03:56:29 UTC 
Verify the bug with below builds:
virt-v2v-1.36.6-1.el7.x86_64
libguestfs-1.36.6-1.el7.x86_64
libvirt-3.7.0-2.el7.x86_64
qemu-kvm-rhev-2.9.0-16.el7_4.8.x86_64


Steps:
1.Convert a guest with snapshot from vmware by virt-v2v
# virt-v2v -ic vpx://root.75.182/data/10.73.3.19/?no_verify=1 -o rhev -os 10.73.131.93:/home/nfs_export -of raw -b ovirtmgmt -n ovirtmgmt Auto-esx5.5-rhel7.1-snapshot  --password-file /tmp/passwd
[   0.0] Opening the source -i libvirt -ic vpx://root.75.182/data/10.73.3.19/?no_verify=1 Auto-esx5.5-rhel7.1-snapshot
'curl' -q --max-redirs '5' --globoff --head --silent --url 'https://10.73.75.182/folder/Auto-esx5.5-rhel7.1-snapshot/Auto-esx5.5-rhel7.1-snapshot-000001-flat.vmdk?dcPath=data&dsName=ESX5.5-auto' --user <hidden> --insecure
HTTP/1.1 404 Not Found
Date: Tue, 19 Sep 2017 03:52:08 GMT
Set-Cookie: vmware_soap_session="c72bf5c64ecc9ac8ecd17b7cdb4d39f0c46b569d"; Path=/; HttpOnly; Secure; 
Connection: close
Content-Type: text; charset=plain
Content-Length: 0

virt-v2v: error: vcenter: URL not found: 
https://10.73.75.182/folder/Auto-esx5.5-rhel7.1-snapshot/Auto-esx5.5-rhel7.1-snapshot-000001-flat.vmdk?dcPath=data&dsName=ESX5.5-auto

If reporting bugs, run virt-v2v with debugging enabled and include the 
complete output:

  virt-v2v -v -x [...]


Result:
   There is no error message about "--dcpath" when convert a snapshot guest from vmware, so move this bug from ON_QA to VERIFIED
Comment 8 errata-xmlrpc 2018-04-10 09:18:10 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0677