Bug 1486483

Summary: Save only used OpenShift images with labels/tags
Product: Red Hat CloudForms Management Engine Reporter: Adam Grare <agrare>
Component: ProvidersAssignee: Adam Grare <agrare>
Status: CLOSED CURRENTRELEASE QA Contact: brahmani
Severity: high Docs Contact:
Priority: unspecified    
Version: 5.7.0CC: akarol, gblomqui, jfrey, jhardy, myoder, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1487323 1494561 (view as bug list) Environment:
Last Closed: 2018-03-06 15:01:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Container Management Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1487323, 1494561    

Description Adam Grare 2017-08-29 22:05:14 UTC
Description of problem:
Some systems have so many container images that it is impractical to collect/parse/save them all.  It is also useful to have full metadata (labels/tags) for images which are in use.

Comment 3 Federico Simoncelli 2017-08-30 15:29:14 UTC
*** Bug 1486484 has been marked as a duplicate of this bug. ***

Comment 5 CFME Bot 2017-08-31 16:41:01 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/212784309e50be74e7f6f4ccbb549cd0358cf99b

commit 212784309e50be74e7f6f4ccbb549cd0358cf99b
Author:     Federico Simoncelli <federico.simoncelli>
AuthorDate: Tue Aug 29 17:08:36 2017 +0200
Commit:     Beni Cherniavsky-Paskin <cben>
CommitDate: Thu Aug 31 18:13:25 2017 +0300

    Backport
    https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/11, https://github.com/ManageIQ/manageiq-providers-openshift/pull/9
    
    Option needed for new ems_refresh.openshift.store_unused_images setting
    
    (cherry picked from https://github.com/ManageIQ/manageiq-providers-kubernetes/commit/0046549b16d166ebdaccbb2ac3ec0cfec84b5cc2)
    
    Add ems_refresh.openshift.store_unused_images setting
    
    (partially cherry picked from https://github.com/ManageIQ/manageiq-providers-openshift/commit/6a62bb2f9cde7f8722f58510b557bfdfc3d77ed6:
    omitted the graph refresh test skip,
    passing options explicitly - constructor didn't set `@options` on euwe,
    adjusted for different test method signature :connected vs :archived,
    simulating missing stub_settings_merge,
    adjusted for different VCR cassette)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1486483

 .../kubernetes/container_manager/refresh_parser.rb |   4 +-
 .../openshift/container_manager/refresh_parser.rb  |  11 +-
 config/settings.yml                                |   2 +
 .../container_manager/refresh_parser_spec.rb       |   9 ++
 .../container_manager/refresh_parser_spec.rb       | 179 +++++++++++++--------
 .../openshift/container_manager/refresher_spec.rb  |  63 ++++++++
 6 files changed, 194 insertions(+), 74 deletions(-)

Comment 7 CFME Bot 2017-09-22 13:56:10 UTC
New commit detected on ManageIQ/manageiq/fine:
https://github.com/ManageIQ/manageiq/commit/162caf9066b1c4f40143af81c06d1e6f669c200d

commit 162caf9066b1c4f40143af81c06d1e6f669c200d
Author:     Federico Simoncelli <federico.simoncelli>
AuthorDate: Tue Aug 29 17:08:36 2017 +0200
Commit:     Beni Cherniavsky-Paskin <cben>
CommitDate: Wed Aug 30 16:43:02 2017 +0300

    Backport
    https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/11, https://github.com/ManageIQ/manageiq-providers-openshift/pull/9
    
    Option needed for new ems_refresh.openshift.store_unused_images setting
    
    (cherry picked from https://github.com/ManageIQ/manageiq-providers-kubernetes/commit/0046549b16d166ebdaccbb2ac3ec0cfec84b5cc2)
    
    Add ems_refresh.openshift.store_unused_images setting
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1486483
    
    (partially cherry picked from https://github.com/ManageIQ/manageiq-providers-openshift/commit/6a62bb2f9cde7f8722f58510b557bfdfc3d77ed6:
    omitted the graph refresh test skip,
    passing options explicitly - constructor didn't set `@options` on fine,
    adjusted for different test method signature :connected vs :archived)

 .../kubernetes/container_manager/refresh_parser.rb |   4 +-
 .../openshift/container_manager/refresh_parser.rb  |  11 +-
 config/settings.yml                                |   1 +
 .../container_manager/refresh_parser_spec.rb       |   9 ++
 .../container_manager/refresh_parser_spec.rb       | 172 +++++++++++++--------
 .../openshift/container_manager/refresher_spec.rb  |  63 ++++++++
 6 files changed, 190 insertions(+), 70 deletions(-)

Comment 8 brahmani 2017-11-07 09:57:46 UTC
Verified on CFME 5.9.0.5 version, pass.
Changing parameter store_unused_images value to false on evm configuration,
after provider refresh, number of container images decrease and sow only the one that used by provider pods.