Bug 1486538
Summary: | [geo-rep+qr]: Crashes observed at slave from qr_lookup_sbk during rename/hardlink/rebalance cases | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Nithya Balachandran <nbalacha> |
Component: | distribute | Assignee: | Nithya Balachandran <nbalacha> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | high | Docs Contact: | |
Priority: | high | ||
Version: | 3.12 | CC: | atumball, bugs, nbalacha, pkarampu, ravishankar, rhinduja, rhs-bugs |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | glusterfs-glusterfs-3.12.1 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | 1484709 | Environment: | |
Last Closed: | 2017-09-14 07:42:56 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1484709 | ||
Bug Blocks: | 1484113, 1488560 |
Description
Nithya Balachandran
2017-08-30 04:26:25 UTC
REVIEW: https://review.gluster.org/18145 (perf/qr: Use a ref-ed data to extract content) posted (#1) for review on release-3.12 by N Balachandran (nbalacha) REVIEW: https://review.gluster.org/18146 (cluster/dht: Aggregate xattrs only for dirs in dht_discover_cbk) posted (#1) for review on release-3.12 by N Balachandran (nbalacha) COMMIT: https://review.gluster.org/18145 committed in release-3.12 by jiffin tony Thottan (jthottan) ------ commit a862ca969cfd4dc9309e8123e6e90c4e47f9b89b Author: N Balachandran <nbalacha> Date: Wed Aug 30 10:01:54 2017 +0530 perf/qr: Use a ref-ed data to extract content qr_content_extract used dict_get to get the value of the GF_CONTENT_KEY key. dict_get does not ref the data before returning it so QR could be acting on freed memory if another thread deletes the key before then. This patch also fixes a race in dict_get_with_ref. Fix: Use dict_get_with_ref to retrieve the file contents. > BUG: 1484709 > Signed-off-by: N Balachandran <nbalacha> > Reviewed-on: https://review.gluster.org/18115 > Smoke: Gluster Build System <jenkins.org> > Reviewed-by: Amar Tumballi <amarts> > Tested-by: Raghavendra G <rgowdapp> > CentOS-regression: Gluster Build System <jenkins.org> > Reviewed-by: Raghavendra G <rgowdapp> Change-Id: Ib1a7a70bb92eed7e70747ec530e0b3edc53127ec BUG: 1486538 (cherry picked from commit 414d3e92fc56f08e320a3aa65b6b18e65b384551) Signed-off-by: N Balachandran <nbalacha> Reviewed-on: https://review.gluster.org/18145 Reviewed-by: Raghavendra G <rgowdapp> Smoke: Gluster Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: MOHIT AGRAWAL <moagrawa> Moving this back to Post as https://review.gluster.org/#/c/18146/ has not yet been merged. COMMIT: https://review.gluster.org/18146 committed in release-3.12 by jiffin tony Thottan (jthottan) ------ commit 268bb635aca729a24242412c6f9dd9d5ba2a2654 Author: N Balachandran <nbalacha> Date: Wed Aug 30 10:36:45 2017 +0530 cluster/dht: Aggregate xattrs only for dirs in dht_discover_cbk If dht_discover finds data files on more than one subvol, racing calls to dht_discover_cbk could end up calling dht_aggregate_xattr which could delete dictionary data that is being accessed by higher layer translators. Fixed to call dht_aggregate_xattr only for directories and consider only the first file to be found. > BUG: 1484709 > Signed-off-by: N Balachandran <nbalacha> > Reviewed-on: https://review.gluster.org/18137 > Smoke: Gluster Build System <jenkins.org> > CentOS-regression: Gluster Build System <jenkins.org> > Reviewed-by: Raghavendra G <rgowdapp> Change-Id: I4f3d2a405ec735d4f1bb33a04b7255eb2d179f8a BUG: 1486538 (cherry picked from commit 9420022df0962b1fa4f3ea3774249be81bc945cc) Signed-off-by: N Balachandran <nbalacha> Reviewed-on: https://review.gluster.org/18146 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Raghavendra G <rgowdapp> Reviewed-by: Amar Tumballi <amarts> CentOS-regression: Gluster Build System <jenkins.org> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-glusterfs-3.12.1, please open a new bug report. glusterfs-glusterfs-3.12.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/gluster-users/2017-September/032441.html [2] https://www.gluster.org/pipermail/gluster-users/ |