Bug 1487532

Summary: disable-multipath.sh script does not add the lines required to blacklist devices in /etc/multipath.conf file.
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: SATHEESARAN <sasundar>
Component: rhhiAssignee: Sahina Bose <sabose>
Status: CLOSED CURRENTRELEASE QA Contact: SATHEESARAN <sasundar>
Severity: high Docs Contact:
Priority: high    
Version: rhhi-1.1CC: knarra, nsoffer, rcyriac, rhs-bugs, sabose, smohan, storage-qa-internal, surs
Target Milestone: ---   
Target Release: RHHI 1.1   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: gdeploy-2.0.2-18 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1477203 Environment:
Last Closed: 2018-01-03 10:53:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1477203    
Bug Blocks: 1486559    

Description SATHEESARAN 2017-09-01 08:00:49 UTC 
Description
------------

Local disks should be blacklisted for RHHI 1.1 


+++ This bug was initially created as a clone of Bug #1477203 +++

Description of problem:
disable-multipath.sh script does not add the lines required to blacklist multipath devices in /etc/multipath.conf file. 
This happens due to the reason that multipathd is running and in the script there is a  line to flush all the multipath entries and this does not work due to the reason that multipath map is in use. When this line in script returns a non zero value script terminates and rest of the script does not get executed.

Version-Release number of selected component (if applicable):
gdeploy-2.0.2-14.el7rhgs.noarch

How reproducible:
Always

Steps to Reproduce:
1. Install RHEL / RHV-H
2. Now login to cockpit and configure 'Hosted Engine with gluster'
3.

Actual results:
Once the deployment is done, entries to black list multipath devices are not present in /etc/multipath.conf file

Expected results:
Entries to black list  multipath devices should be added to /etc/multipath.conf

Additional info:

Not proposing this as a blocker for now due to the fact that we are not aware of the steps on how to flush and black list devices when multipathd is running. Once we have the steps i will propose this as blocker.

--- Additional comment from Red Hat Bugzilla Rules Engine on 2017-08-01 09:10:09 EDT ---

This bug is automatically being proposed for the current release of Red Hat Gluster Storage 3 under active development, by setting the release flag 'rhgs‑3.3.0' to '?'. 

If this bug should be proposed for a different release, please manually change the proposed release flag.

--- Additional comment from Sahina Bose on 2017-08-02 00:57:08 EDT ---

Hi Nir,

Do you know or point me to someone who would know the steps to blacklist devices?

What's currently in place as per https://github.com/gluster/gdeploy/blob/2.0.2/extras/scripts/blacklist_all_disks.sh :
1. call multipath -F
2. edit /etc/multipath.conf to blacklist devices

This errors out in step 1.

--- Additional comment from Red Hat Bugzilla Rules Engine on 2017-08-02 07:53:19 EDT ---

This BZ having been considered, and subsequently not approved to be fixed at the RHGS 3.3.0 release, is being proposed for the next minor release of RHGS
Comment 1 SATHEESARAN 2017-09-01 09:40:32 UTC 
This change as requested in this bug is much required for the RHHI 1.1 release.
Without this, the local disks uses the mpath names ( with WWIDs ) and that becomes hard for deployment and brick creation in future.
Comment 3 SATHEESARAN 2017-11-10 07:30:15 UTC 
The dependent bug in gdeploy is already verified by Kasturi.
Marking this RHHI bug as verified with the details mentioned in the comment[1]

[1] - https://bugzilla.redhat.com/show_bug.cgi?id=1477203#c18