Bug 1487595

Fixed Urls:

  Spec URL:  https://pagure.io/besser82/package-review/raw/master/f/python34-gobject.spec
  SRPM URL:  https://pagure.io/besser82/package-review/raw/master/f/python34-gobject-3.22.0-1.el7.src.rpm

Approved

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Package contains BR: python2-devel or python3-devel


===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL", "Unknown or generated", "MIT/X11 (BSD like)", "*No
     copyright* LGPL", "LGPL (v3 or later)", "LGPL (v2.1 or later)", "FSF
     All Permissive", "*No copyright* LGPL (v2.1 or later)". 101 files have
     unknown license. Detailed output of licensecheck in
     /home/leigh/1487595-python34-gobject/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/python3.4/site-
     packages, /usr/lib64/python3.4
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/include/pygobject-3.0(pygobject3-devel)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 174080 bytes in 7 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[ ]: Python eggs must not download any dependencies during the build
     process.
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python34
     -gobject-base , python34-gobject-devel , python34-gobject-debuginfo
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.4.3 starting (python version = 3.6.2)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled yum cache
Start: cleaning yum metadata
Finish: cleaning yum metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.3
INFO: Mock Version: 1.4.3
Finish: chroot init
INFO: installing package(s): /home/leigh/1487595-python34-gobject/results/python34-gobject-base-3.22.0-1.el7.centos.x86_64.rpm /home/leigh/1487595-python34-gobject/results/python34-gobject-debuginfo-3.22.0-1.el7.centos.x86_64.rpm /home/leigh/1487595-python34-gobject/results/python34-gobject-devel-3.22.0-1.el7.centos.x86_64.rpm /home/leigh/1487595-python34-gobject/results/python34-gobject-3.22.0-1.el7.centos.x86_64.rpm
ERROR: Command failed: 
 # /usr/bin/yum-deprecated --installroot /var/lib/mock/epel-7-x86_64/root/ --releasever 7 install /home/leigh/1487595-python34-gobject/results/python34-gobject-base-3.22.0-1.el7.centos.x86_64.rpm /home/leigh/1487595-python34-gobject/results/python34-gobject-debuginfo-3.22.0-1.el7.centos.x86_64.rpm /home/leigh/1487595-python34-gobject/results/python34-gobject-devel-3.22.0-1.el7.centos.x86_64.rpm /home/leigh/1487595-python34-gobject/results/python34-gobject-3.22.0-1.el7.centos.x86_64.rpm



Rpmlint
-------
Checking: python34-gobject-3.22.0-1.el7.centos.x86_64.rpm
          python34-gobject-base-3.22.0-1.el7.centos.x86_64.rpm
          python34-gobject-devel-3.22.0-1.el7.centos.x86_64.rpm
          python34-gobject-debuginfo-3.22.0-1.el7.centos.x86_64.rpm
          python34-gobject-3.22.0-1.el7.centos.src.rpm
python34-gobject.x86_64: W: incoherent-version-in-changelog 3.22.0-1 ['3.22.0-1.el7.centos', '3.22.0-1.centos']
python34-gobject.x86_64: W: no-documentation
python34-gobject-base.x86_64: W: spelling-error %description -l en_US cairo -> Cairo, cairn
python34-gobject-devel.x86_64: W: only-non-binary-in-usr-lib
python34-gobject-devel.x86_64: E: wrong-script-interpreter /usr/share/doc/python34-gobject-devel-3.22.0/examples/cairo-demo.py /usr/bin/env python
python34-gobject-devel.x86_64: E: wrong-script-interpreter /usr/share/doc/python34-gobject-devel-3.22.0/examples/option.py /usr/bin/env python
python34-gobject-devel.x86_64: W: doc-file-dependency /usr/share/doc/python34-gobject-devel-3.22.0/examples/cairo-demo.py /usr/bin/env
python34-gobject.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 6)
5 packages and 0 specfiles checked; 2 errors, 6 warnings.




Requires
--------
python34-gobject-debuginfo (rpmlib, GLIBC filtered):

python34-gobject-devel (rpmlib, GLIBC filtered):
    /usr/bin/env
    /usr/bin/pkg-config
    gobject-introspection-devel(x86-64)
    pkgconfig(gobject-2.0)
    pkgconfig(libffi)
    python34-gobject-gobject(x86-64)

python34-gobject-base (rpmlib, GLIBC filtered):
    gobject-introspection(x86-64)
    libc.so.6()(64bit)
    libffi.so.6()(64bit)
    libgirepository-1.0.so.1()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgthread-2.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    python(abi)
    rtld(GNU_HASH)

python34-gobject (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libcairo-gobject.so.2()(64bit)
    libcairo.so.2()(64bit)
    libgirepository-1.0.so.1()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    python(abi)
    python34-cairo(x86-64)
    python34-gobject-base(x86-64)
    rtld(GNU_HASH)



Provides
--------
python34-gobject-debuginfo:
    python34-gobject-debuginfo
    python34-gobject-debuginfo(x86-64)

python34-gobject-devel:
    pkgconfig(pygobject-3.0)
    python34-gobject-devel
    python34-gobject-devel(x86-64)

python34-gobject-base:
    python34-gobject-base
    python34-gobject-base(x86-64)

python34-gobject:
    python34-gobject
    python34-gobject(x86-64)



Unversioned so-files
--------------------
python34-gobject: /usr/lib64/python3.4/site-packages/gi/_gi_cairo.cpython-34m.so
python34-gobject-base: /usr/lib64/python3.4/site-packages/gi/_gi.cpython-34m.so

Source checksums
----------------
https://download.gnome.org/sources/pygobject/3.22/pygobject-3.22.0.tar.xz :
  CHECKSUM(SHA256) this package     : 08b29cfb08efc80f7a8630a2734dec65a99c1b59f1e5771c671d2e4ed8a5cbe7
  CHECKSUM(SHA256) upstream package : 08b29cfb08efc80f7a8630a2734dec65a99c1b59f1e5771c671d2e4ed8a5cbe7


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m epel-7-x86_64 -b 1487595
Buildroot used: epel-7-x86_64
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Any news on this one?  #1479083 is pending on the completion....

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python3-gobject3

python3-gobject3-3.22.0-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2621361489

python3-gobject3-3.22.0-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2621361489

python3-gobject3-3.22.0-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.