Bug 1487602
| Summary: | [RFE][M-5] Targeted Refresh for Azure Provider | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Niladri Roy <niroy> | |
| Component: | Providers | Assignee: | Ladislav Smola <lsmola> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Ievgen Zapolskyi <izapolsk> | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 5.8.0 | CC: | abellott, bsorota, cpelland, dberger, gblomqui, jfrey, jhardy, jocarter, jprause, lavenel, lsmola, mfeifer, mshriver, obarenbo, simaishi | |
| Target Milestone: | MVP | Keywords: | FutureFeature, RFE, TestOnly, ZStream | |
| Target Release: | 5.10.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | 5.10.0.0 | Doc Type: | Enhancement | |
| Doc Text: |
Targeted refresh is disabled by default, we turn it on by turning on graph refresh in advanced settings under:
:azure
:inventory_object_refresh: true
:azure_network
:inventory_object_refresh: true
With :inventory_object_refresh: true, targeted refresh is then enabled by default, can be disabled by setting:
:allow_targeted_refresh: false
------
More settings were added that can be used to tweak performance, see new settings added in https://github.com/ManageIQ/manageiq-providers-azure/pull/220/files#diff-646ad6b10917e4385cbcc8c8524e24a2R39
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 1558078 (view as bug list) | Environment: | ||
| Last Closed: | 2019-02-11 13:55:08 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | CFME Core | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1555371, 1558078 | |||
|
Comment 8
Bronagh Sorota
2018-01-08 15:31:14 UTC
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/55c716363ffddcef8bd1c2f2ec82d17895488ea0 commit 55c716363ffddcef8bd1c2f2ec82d17895488ea0 Author: Ladislav Smola <lsmola> AuthorDate: Wed Feb 28 17:04:40 2018 +0100 Commit: Ladislav Smola <lsmola> CommitDate: Wed Feb 28 22:10:53 2018 +0100 Correct targeted_arel joined with load_balancer Correct targeted_arel joined with load_balancer. For AWS, it was ok to join to pool, which had the same ems_ref as lb. But for Azure, the pool has different ems_ref, so we need to correctly join every table to load_balancers table and filter there Partially fixes https://bugzilla.redhat.com/show_bug.cgi?id=1487602 app/models/load_balancer_pool.rb | 1 + .../network_manager.rb | 46 ++++++++++++++-------- 2 files changed, 31 insertions(+), 16 deletions(-) New commit detected on ManageIQ/manageiq-content/master: https://github.com/ManageIQ/manageiq-content/commit/dd28f188b07025b520d8bf3dbbfb8c1477f0e7aa commit dd28f188b07025b520d8bf3dbbfb8c1477f0e7aa Author: Ladislav Smola <lsmola> AuthorDate: Tue Mar 6 06:12:36 2018 -0500 Commit: Ladislav Smola <lsmola> CommitDate: Tue Mar 6 06:12:36 2018 -0500 Switch to targeted refresh action Switch to targeted refresh action, which can be turned into full refresh by configuration. Partially fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1487602 content/automate/ManageIQ/System/Event/EmsEvent/Azure.class/networksecuritygroups_write_endrequest.yaml | 2 +- content/automate/ManageIQ/System/Event/EmsEvent/Azure.class/subscriptions_resourcegroups_endrequest.yaml | 2 +- content/automate/ManageIQ/System/Event/EmsEvent/Azure.class/virtualmachines_capture_endrequest.yaml | 2 +- content/automate/ManageIQ/System/Event/EmsEvent/Azure.class/virtualmachines_deallocate_endrequest.yaml | 2 +- content/automate/ManageIQ/System/Event/EmsEvent/Azure.class/virtualmachines_delete_endrequest.yaml | 2 +- content/automate/ManageIQ/System/Event/EmsEvent/Azure.class/virtualmachines_poweroff_endrequest.yaml | 2 +- content/automate/ManageIQ/System/Event/EmsEvent/Azure.class/virtualmachines_restart_endrequest.yaml | 2 +- content/automate/ManageIQ/System/Event/EmsEvent/Azure.class/virtualmachines_start_endrequest.yaml | 2 +- content/automate/ManageIQ/System/Event/EmsEvent/Azure.class/virtualmachines_write_endrequest.yaml | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) Satoe: this is the order we should backport the PRs # Workers consolidation https://github.com/ManageIQ/manageiq/pull/17076 https://github.com/ManageIQ/manageiq-providers-azure/pull/216 # Graph Refresh + Targeted refresh + EventParser https://github.com/ManageIQ/manageiq/pull/17070 https://github.com/ManageIQ/manageiq-providers-azure/pull/212 https://github.com/ManageIQ/manageiq-providers-azure/pull/217 https://github.com/ManageIQ/manageiq-providers-azure/pull/219 https://github.com/ManageIQ/manageiq-providers-azure/pull/220 https://github.com/ManageIQ/manageiq-providers-azure/pull/222 # Automate event handlers https://github.com/ManageIQ/manageiq-content/pull/260 https://github.com/ManageIQ/manageiq-content/pull/261 Satoe: scratch comment #16, this is the order we should backport the PRs (222 needs to go before 200) # Workers consolidation https://github.com/ManageIQ/manageiq/pull/17076 https://github.com/ManageIQ/manageiq-providers-azure/pull/216 # Graph Refresh + Targeted refresh + EventParser https://github.com/ManageIQ/manageiq/pull/17070 https://github.com/ManageIQ/manageiq-providers-azure/pull/212 https://github.com/ManageIQ/manageiq-providers-azure/pull/217 https://github.com/ManageIQ/manageiq-providers-azure/pull/219 https://github.com/ManageIQ/manageiq-providers-azure/pull/222 https://github.com/ManageIQ/manageiq-providers-azure/pull/220 # Automate event handlers https://github.com/ManageIQ/manageiq-content/pull/260 https://github.com/ManageIQ/manageiq-content/pull/261 Satoe scratch https://bugzilla.redhat.com/show_bug.cgi?id=1487602#c17 , this is the final order of PRs we need to keep for backport: # Workers consolidation https://github.com/ManageIQ/manageiq/pull/17076 https://github.com/ManageIQ/manageiq-providers-azure/pull/216 # Graph Refresh + Targeted refresh + EventParser https://github.com/ManageIQ/manageiq/pull/17070 https://github.com/ManageIQ/manageiq-providers-azure/pull/212 https://github.com/ManageIQ/manageiq-providers-azure/pull/217 https://github.com/ManageIQ/manageiq-providers-azure/pull/219 https://github.com/ManageIQ/manageiq-providers-azure/pull/222 https://github.com/ManageIQ/manageiq-providers-azure/pull/220 # Automate event handlers https://github.com/ManageIQ/manageiq-content/pull/260 https://github.com/ManageIQ/manageiq-content/pull/261 # More fixes for events https://github.com/ManageIQ/manageiq-providers-azure/pull/226 https://github.com/ManageIQ/manageiq-providers-azure/pull/225 Verified in 5.10.0.16 |