Bug 1487741

Unfortunately I've not personally used gallery2 in some time.  It's also dead upstream, as is, I believe, it's successor, gallery3.  My suspicion is that gallery2 doesn't work with PHP 7, which has been in Fedora since Fedora 25.  I'm not sure if gallery3 works with PHP 7.  I would suggest one of the following:

1. Try gallery2 on CentOS 7.
2. Try gallery3 on Fedora 26.
3. Try gallery2 from an upstream download rather than the RPM, in case it's a packaging bug and not a PHP version issue.

I may need to retire gallery2.

I'm using gallery2 on PHP 7 without a problem. It is an existing install.

Yes, upstream is dead for gallery2 and gallery3.

I'm using gallery2 with PostgreSQL. I don't know if MariaDB will work as it has deviated from MySQL slightly. Please try using PostgreSQL instead (a better choice anyway IMHO).

Interesting.

A. I see the client address in the above isn't 127.0.0.1, did you edit /etc/httpd/conf.d/gallery2.conf to allow that?

B. If gallery2 still can't find mariadb, if you don't want to change to PostgreSQL, try community-mysql.

Michael and Gwyn:
Thank you for taking an interest...

It would be truly sad if gallery[23] became unusable.
1) - it's a good program
2) - I have a ginormous collection of annotated family pics.

B - ...can't fine mariadb...
I seriously doubt that's the problem.  It doesn't seem that my rejection from the  'install' module ever got near the stage of trying to access the database.  In addition, according to my notes, when I last had gallery2 working (Fedora 24), it was working with mariadb.

A - I have most certainly have NOT edited /etc/httpd/conf.d/gallery2.conf, nor anything else in /etc/httpd/.  That's why I am dismayed that gallery2 and apache, as delivered, don't work together.  It seems likely that I am expected to edit some esoteric permissions or access rights for apache, but I haven't a clue what that might be.

For completeness, here's my /etc/httpd/conf.d/gallery2.conf file:

$ cat gallery2.conf
Alias /gallery2 /usr/share/gallery2

<Directory /usr/share/gallery2>
  AllowOverride Options FileInfo
</Directory>

I see nothing there that permits or restricts an IP address.

I can address the install module three different ways:  
  datix.us/gallery2/install
  datium/gallery2/install
  localhost/gallery2/install

The response in the firefox window is the same:
  Forbidden
  You don't have permission to access /gallery2/install on this server.

However the message in /var/log/httpd/error_log is a tiny bit different:

[Tue Sep 05 14:26:13.917280 2017] [authz_core:error] [pid 1225] [client 192.168.2.1:36392] AH01630: client denied by server configuration: /usr/share/gallery2/install

[Tue Sep 05 14:27:04.825909 2017] [authz_core:error] [pid 2980] [client 192.168.2.2:42014] AH01630: client denied by server configuration: /usr/share/gallery2/install

[Tue Sep 05 14:28:03.067990 2017] [authz_core:error] [pid 1227] [client ::1:58380] AH01630: client denied by server configuration: /usr/share/gallery2
/install

Using the public name (datix.us), the request comes from the router (192.168.2.1).
Using the local name (datium), the request comes from datium (192.168.2.2).
Using localhost, the request comes from ::1.

Firewalld is running, but I don't think that affects the public ports (36392, 42014, or 58380).  Selinux is disabled.

Is there anything I can change in the httpd hierarchy to make the error messages more informative.   ...or make it work!   :-)

Hmm, so it's not a firewall or selinux issue.

[authz_core:error] What configuration does this system have around authz?

Wow!  I have achieved utopia.  I have on my screen  Gallery Installer!
and can proceed to configuring gallery2.

Wanna know how?

First, Gwyn, I have never heard of authz; have no package on my system whose name includes that string; haven't the foggiest idea of what "configuration" it has.

However, googling for "authz_core:error" turned up an obscure quote
on a slightly different problem:	

Change your authorization configuration:

<Directory /home/remix/>
    #...
    Order allow,deny
    Allow from all
</Directory>

...to the Apache 2.4 version of the same.

<Directory /home/remix/>
    #...
    Require all granted
</Directory>

This suggestion was made 
  Aug 20 '12 at 15:36 by
  Shane Madden
- over five years ago!

I duly edited /etc/httpd/conf.d/gallery2.conf to read:
Alias /gallery2 /usr/share/gallery2

<Directory /usr/share/gallery2>
##  AllowOverride Options FileInfo
    Require all granted
</Directory>

and now it works; I can enter the sanctum sanctorum of gallery2/install.

This is, as they say, a mystery wrapped in an enigma.
I have no idea why it works or where I could look for a rational explanation.
Apparently, apache changed their cryptic security overlay and no one noticed.

But it is SURELY a bug in the packaging of gallery2.
I hope someone will fix it, please.

Thanks for all the help, Gwyn.

Wow, good work.  Yes, it is a packaging bug. I'll get out updates with a patched conf ASAP.

Thank you!

gallery2-2.3.2-18.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6a77ccbbd1

gallery2-2.3.2-18.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-570113bdc9

gallery2-2.3.2-18.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b624fd8ad0

OK, that was the EASY one.  :-)

Working my way through  Gallery2 Installer  I got to Step 8 	Install Gallery Core - which generated a ton of error messages, terminating in a Fatal error: !

I've cut 'n pasted it all to a file (3063 lines - half are blank spacers) and then edited out 81 + 68 + 39 duplicates, leaving a file of 501 lines (half blank), which I will attach for your reading pleasure.

I suppose the vast number of "Deprecated: ..." messages are just warnings and can be ignored.  However the "Fatal Error:" cannot.

I can't make sense of that message.  Can you?

Created attachment 1323410 [details]
Error msgs from "8 	Install Gallery Core "

Eek.

Given that my PHP knowledge is rusty and somewhat stale since PHP7, I'd recommend finding someone more expert than myself in PHP exception handling.

The issue is that I introduced a bug with the gallery2-php-warnings.patch to get some warnings squashed. I set a variable to null, but the code David is hitting is trying to use that variable and dereference it into a function. I will fix it.

Excellent, thank you!

gallery2-2.3.2-18.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b624fd8ad0

gallery2-2.3.2-19.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b624fd8ad0

Michael, thank you for your efforts to fix this code.  Please concentrate on the "Fatal Error:" segment.

Gwyn, if your "PHP knowledge is rusty", imagine how I feel.
With my level of expertise, I shouldn't even be allowed to think about this next question:
I wonder if any other packages have ignored the notation change in Apache 2.4.
So I looked for use of the problematic "AllowOverride":

[root@datium /etc/httpd]
# grep -r AllowOverride *
conf/httpd.conf:    AllowOverride none
conf/httpd.conf:    AllowOverride None
conf/httpd.conf:    # AllowOverride controls what directives may be placed in .htaccess files.
conf/httpd.conf:    AllowOverride None
conf/httpd.conf:    AllowOverride None
conf.d/gallery2.conf:##  AllowOverride Options FileInfo
conf.d/autoindex.conf:    AllowOverride None
conf.d/welcome.conf:    AllowOverride None
conf.d/gallery2.confSTD:  AllowOverride Options FileInfo
conf.d/userdir.conf:    AllowOverride FileInfo AuthConfig Limit Indexes
conf.d/mythweb.conf:        AllowOverride   All

Only userdir.conf looks suspicious to me.  I wonder if that usage is correct;  if not, what surprises lurk for the unwary?

Please try the new build as it contains the fix for the PHP error.

gallery2-2.3.2-19

F27: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b624fd8ad0
F26: https://koji.fedoraproject.org/koji/buildinfo?buildID=968103
F25: https://koji.fedoraproject.org/koji/buildinfo?buildID=968105

(In reply to David A. De Graaf from comment #18)
> Michael, thank you for your efforts to fix this code.  Please concentrate on
> the "Fatal Error:" segment.
> 
> Gwyn, if your "PHP knowledge is rusty", imagine how I feel.
> With my level of expertise, I shouldn't even be allowed to think about this
> next question:
> I wonder if any other packages have ignored the notation change in Apache
> 2.4.
> So I looked for use of the problematic "AllowOverride":
> 
> [root@datium /etc/httpd]
> # grep -r AllowOverride *
> conf/httpd.conf:    AllowOverride none
> conf/httpd.conf:    AllowOverride None
> conf/httpd.conf:    # AllowOverride controls what directives may be placed
> in .htaccess files.
> conf/httpd.conf:    AllowOverride None
> conf/httpd.conf:    AllowOverride None
> conf.d/gallery2.conf:##  AllowOverride Options FileInfo
> conf.d/autoindex.conf:    AllowOverride None
> conf.d/welcome.conf:    AllowOverride None
> conf.d/gallery2.confSTD:  AllowOverride Options FileInfo
> conf.d/userdir.conf:    AllowOverride FileInfo AuthConfig Limit Indexes
> conf.d/mythweb.conf:        AllowOverride   All
> 
> Only userdir.conf looks suspicious to me.  I wonder if that usage is
> correct;  if not, what surprises lurk for the unwary?

Entirely possible.  Please file bugs as needed. :)

Michael, we're making progress, but aren't there yet.
The new build for F26, F26: https://koji.fedoraproject.org/koji/buildinfo?buildID=968103 got almost to the end, but failed at Step 9 -
Install Plugins - with this display:

Not Found

The requested URL /gallery2/install/<br /><b>Deprecated</b>: Non-static method GallerySetupUtilities::areCookiesSupported() should not be called statically in <b>/usr/share/gallery2/install/index.php</b> on line <b>319</b><br />index.php was not found on this server.

The previous Step 8 - Install Gallery Core  elicited 11 "Deprecated:" warnings,
a gigantic improvement from before.  I'll include them as an attachment.

Incidentally, your "Please try the new build ..." left a bit to the imagination.
I'm not familiar with koji magic, so tediously clicked on each of the 76 packages to download them, one by one.  Then   'dnf update ./g*'  worked perfectly.
I'm sure there's an easier way...

Created attachment 1323934 [details]
Error msgs from installing gallery2.noarch 2.3.2-19.fc26

Thanks for the log. Can you check the "error_log" of apache? Default directory: /var/log/httpd/

If there is nothing that explains the "not found" message there then I would have to guess there is an issue with the Apache config.

(In reply to David A. De Graaf from comment #21)
> Incidentally, your "Please try the new build ..." left a bit to the
> imagination.
> I'm not familiar with koji magic, so tediously clicked on each of the 76
> packages to download them, one by one.  Then   'dnf update ./g*'  worked
> perfectly.
> I'm sure there's an easier way...

Yes, you can use "koji download-build <build#>" to grab them all at once.

gallery2-2.3.2-18.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6a77ccbbd1

gallery2-2.3.2-18.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-570113bdc9

gallery2-2.3.2-19.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-570113bdc9

gallery2-2.3.2-19.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6a77ccbbd1

gallery2-2.3.2-19.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b624fd8ad0

gallery2-2.3.2-19.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-570113bdc9

gallery2-2.3.2-19.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6a77ccbbd1

gallery2-2.3.2-19.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

gallery2-2.3.2-19.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

gallery2-2.3.2-19.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Michael Cronenworth and Gwyn Ciesla:

I would like to close out this BZ with some comments.

I should have paid closer attention to the implications of
Comment 1 and realized that the gallery project is dead and
has been since 2014-06-20 - RIP.
This is confirmed in
   http://galleryproject.org/time-to-hibernate

Therefore, it is pointless to spend effort on fixing this broken
package.  Instead, in my opinion, the gallery2 and gallery3 packages
should be withdrawn.  That's sad, but it's reality.

There is a viable and reasonable replacement - piwigo - details at
   piwigo.org
This is an active project;  version 2.9.2 was released Oct 6, 2017.
Installation was dead easy.  I simply downloaded piwigo-2.9.2.zip,
unzip'd it, creating a new directory piwigo/,  rsync'd that entire
subtree to /var/www/html/datix/piwigo/, changed that name to photos/.
Then I created a new empty mariadb database, piwigo, alongside the
gallery2 database.  Then pointed firefox at datix.us/photos and,
bingo - "Congratulations, Piwigo installation is completed".

Perhaps best of all, there is a plugin called Menalto2Piwigo that
converts gallery2 data to piwigo data, automatically and flawlessly.

I really appreciate your efforts in trying to resuscitate gallery2
but it's time to give up I think.  I apologize for asking for help
in flogging this dead horse.

(In reply to David A. De Graaf from comment #35)

Agreed. I myself am prone to flogging dead horses, as I often use "legacy" software that still works.  I even maintain at least on package for Fedora where upstream is long gone but the code still builds and works and I use it.

I'll retire gallery2 and gallery3; they won't be available as of f28, and I'll  include a link to piwigo in the retirement notes.

If you'd like to see it packaged, please reach out to some of the more active PHP application packagers. I've largely stopped using PHP, and am so out of touch with it's current state that I really shouldn't be the one to take on new packages using it at this point.

Please don't be so quick to take action. I will still want to maintain gallery2. It works for me and I still have a live instance.

I've already retired both, but you should be able to take ownership.

Gwyn, please check ACLs next time.

I was the primary admin of gallery2.

Thanks.

My apologies.