Bug 1487749

Summary: MiqEvent or EVM Event always has current VM owner as user, not UI user of event initiator
Product: Red Hat CloudForms Management Engine Reporter: Jared Deubel <jdeubel>
Component: AutomateAssignee: Lucy Fu <lufu>
Status: CLOSED ERRATA QA Contact: Ievgen Zapolskyi <izapolsk>
Severity: medium Docs Contact:
Priority: high    
Version: 5.7.0CC: abellott, izapolsk, jhardy, lufu, mkanoor, obarenbo, saali, simaishi, tfitzger
Target Milestone: GAFlags: izapolsk: automate_bug+
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.9.0.5 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-01 13:16:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 3 Greg McCullough 2017-09-07 17:04:32 UTC
Lucy - I think we are always calling tenant_identity to determine the user which makes sense for events coming from an external system, but is it possible to reference the current user for internal events like request_vm_reboot_guest?

Comment 12 CFME Bot 2017-10-27 14:44:56 UTC
New commit detected on ManageIQ/manageiq-schema/master:
https://github.com/ManageIQ/manageiq-schema/commit/28ed7452f752903e45b1ede86a6415614d2302e2

commit 28ed7452f752903e45b1ede86a6415614d2302e2
Author:     Lucy Fu <lufu>
AuthorDate: Mon Oct 16 15:31:27 2017 -0400
Commit:     Lucy Fu <lufu>
CommitDate: Mon Oct 16 15:49:36 2017 -0400

    Add user_id,group_id,tenant_id to EventStream.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1487749

 db/migrate/20171016192352_add_user_to_event_stream.rb | 7 +++++++
 db/schema.yml                                         | 3 +++
 2 files changed, 10 insertions(+)
 create mode 100644 db/migrate/20171016192352_add_user_to_event_stream.rb

Comment 13 CFME Bot 2017-10-27 14:55:10 UTC
New commit detected on ManageIQ/manageiq-automation_engine/master:
https://github.com/ManageIQ/manageiq-automation_engine/commit/d6d39bbac71da027c0a6ce5f64b31efec243aa4d

commit d6d39bbac71da027c0a6ce5f64b31efec243aa4d
Author:     Lucy Fu <lufu>
AuthorDate: Wed Oct 11 08:55:30 2017 -0400
Commit:     Lucy Fu <lufu>
CommitDate: Wed Oct 18 09:50:52 2017 -0400

    Get the current user if user context is set.
    
    When sending events to automate, use the user context if it is available.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1487749

 lib/miq_automation_engine/engine/miq_ae_event.rb | 7 +++++--
 spec/miq_ae_event_spec.rb                        | 9 +++++++++
 2 files changed, 14 insertions(+), 2 deletions(-)

Comment 14 CFME Bot 2017-10-27 18:56:45 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/940e56998c87b6aa8147a6c9062f846d76085e33

commit 940e56998c87b6aa8147a6c9062f846d76085e33
Author:     Lucy Fu <lufu>
AuthorDate: Wed Oct 11 18:31:57 2017 -0400
Commit:     Lucy Fu <lufu>
CommitDate: Fri Oct 27 12:11:29 2017 -0400

    Store the event initiator in MiqEvent object.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1487749

 app/models/miq_event.rb                        | 11 ++++++++++-
 app/models/mixins/process_tasks_mixin.rb       | 20 ++++++++++++++++----
 app/models/vm_or_template.rb                   |  7 +++++++
 spec/models/miq_event_spec.rb                  | 14 ++++++++++++++
 spec/models/mixins/process_tasks_mixin_spec.rb |  6 +++++-
 spec/models/vm_spec.rb                         |  1 +
 6 files changed, 53 insertions(+), 6 deletions(-)

Comment 15 CFME Bot 2017-10-29 23:46:43 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/3e0e4fe9f8d69396a359469bbb9785f75d534375

commit 3e0e4fe9f8d69396a359469bbb9785f75d534375
Author:     Lucy Fu <lufu>
AuthorDate: Fri Oct 27 19:08:11 2017 -0400
Commit:     Lucy Fu <lufu>
CommitDate: Fri Oct 27 19:08:11 2017 -0400

    Store the event initiator in MiqEvent object when user info is available.
    
    Follow up of PR https://github.com/ManageIQ/manageiq/pull/16179.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1487749

 app/models/miq_event.rb                        | 13 ++++---
 app/models/mixins/process_tasks_mixin.rb       | 40 +++++++++++-----------
 app/models/vm_or_template.rb                   | 47 ++++++++++++--------------
 spec/models/mixins/process_tasks_mixin_spec.rb |  6 +---
 spec/models/vm_spec.rb                         |  1 -
 5 files changed, 48 insertions(+), 59 deletions(-)

Comment 16 Ievgen Zapolskyi 2017-11-20 16:10:58 UTC
verified in 5.9.0.9 


[root@dhcp-8-196-244 log]# grep  "User%3A%3Auser=34" automation.log|head -5 -
[----] I, [2017-11-20T08:48:45.087057 #13152:c1b13c]  INFO -- : Instantiating [/System/Process/Event?EventStream%3A%3Aevent_stream=446&ExtManagementSystem%3A%3Aext_management_system=1&Host%3A%3Ahost=2&MiqEvent%3A%3Amiq_event=446&MiqServer%3A%3Amiq_server=2&User%3A%3Auser=34&VmOrTemplate%3A%3Avm=41&event_stream_id=446&event_type=request_vm_poweroff&ext_management_system_id=1&host_id=2&miq_event_id=446&object_name=Event&vm_id=41&vmdb_object_type=vm]
[----] I, [2017-11-20T08:48:45.104355 #13152:c1b13c]  INFO -- : Updated namespace [/System/Process/Event?EventStream%3A%3Aevent_stream=446&ExtManagementSystem%3A%3Aext_management_system=1&Host%3A%3Ahost=2&MiqEvent%3A%3Amiq_event=446&MiqServer%3A%3Amiq_server=2&User%3A%3Auser=34&VmOrTemplate%3A%3Avm=41&event_stream_id=446&event_type=request_vm_poweroff&ext_management_system_id=1&host_id=2&miq_event_id=446&object_name=Event&vm_id=41&vmdb_object_type=vm  ManageIQ/System]
[----] I, [2017-11-20T08:54:02.563810 #13152:c1b13c]  INFO -- : Instantiating [/System/Process/Event?EventStream%3A%3Aevent_stream=501&ExtManagementSystem%3A%3Aext_management_system=1&Host%3A%3Ahost=2&MiqEvent%3A%3Amiq_event=501&MiqServer%3A%3Amiq_server=2&User%3A%3Auser=34&VmOrTemplate%3A%3Avm=41&event_stream_id=501&event_type=request_vm_start&ext_management_system_id=1&host_id=2&miq_event_id=501&object_name=Event&vm_id=41&vmdb_object_type=vm]
[----] I, [2017-11-20T08:54:02.584606 #13152:c1b13c]  INFO -- : Updated namespace [/System/Process/Event?EventStream%3A%3Aevent_stream=501&ExtManagementSystem%3A%3Aext_management_system=1&Host%3A%3Ahost=2&MiqEvent%3A%3Amiq_event=501&MiqServer%3A%3Amiq_server=2&User%3A%3Auser=34&VmOrTemplate%3A%3Avm=41&event_stream_id=501&event_type=request_vm_start&ext_management_system_id=1&host_id=2&miq_event_id=501&object_name=Event&vm_id=41&vmdb_object_type=vm  ManageIQ/System]
[----] I, [2017-11-20T09:25:41.186749 #13143:c1b13c]  INFO -- : Instantiating [/System/Process/Event?EventStream%3A%3Aevent_stream=791&ExtManagementSystem%3A%3Aext_management_system=1&Host%3A%3Ahost=2&MiqEvent%3A%3Amiq_event=791&MiqServer%3A%3Amiq_server=2&User%3A%3Auser=34&VmOrTemplate%3A%3Avm=41&event_stream_id=791&event_type=request_vm_reset&ext_management_system_id=1&host_id=2&miq_event_id=791&object_name=Event&vm_id=41&vmdb_object_type=vm]

Comment 19 errata-xmlrpc 2018-03-01 13:16:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0380