Bug 1488223

Summary: bodhi-client does not require, recommend or suggest koji, but needs it for 'bodhi updates download'
Product: [Fedora] Fedora Reporter: Adam Williamson <awilliam>
Component: bodhiAssignee: Randy Barlow <randy>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: fzatlouk, jeremy, lewk, randy
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: bodhi-2.10.1-4.fc28, bodhi-2.10.1-3.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-20 13:45:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Adam Williamson 2017-09-04 17:59:17 UTC
If you don't have the 'koji' package installed, 'bodhi updates download' blows up with a "No such file or directory" error, when the `download` method tries to do this:

                    args = ('koji', 'download-build', '--arch=noarch',
                            '--arch={0}'.format(platform.machine()), build['nvr'])
                    ret = subprocess.call(args)

however, bodhi-client has no hard or soft dependency on 'koji' (the package that provides the 'koji' CLI tool).

Comment 1 Randy Barlow 2017-09-15 18:25:19 UTC
D'oh. I think this happened when the Koji code moved to python2-koji. I did a silly thing and s/koji/python2-koji in the spec file, not considering that the CLI actually uses /usr/bin/koji and not actually the Python 2 library (the server does use the Python 2 library).

Easy fix and three people have told me about it so far, so it's a good Friday afternoon activity for me. Thanks for the report!

Comment 2 Randy Barlow 2017-09-15 18:26:25 UTC
*** Bug 1492085 has been marked as a duplicate of this bug. ***

Comment 3 Randy Barlow 2017-09-15 18:28:54 UTC
Technically the client package does import koji, so it should require both koji and python2-koji.

Comment 4 Fedora Update System 2017-09-15 19:44:33 UTC
bodhi-2.10.1-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2bc58910e7

Comment 5 Fedora Update System 2017-09-15 19:44:42 UTC
bodhi-2.10.1-4.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fdea4b5858

Comment 6 Fedora Update System 2017-09-16 18:22:33 UTC
bodhi-2.10.1-4.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fdea4b5858

Comment 7 Fedora Update System 2017-09-17 10:50:50 UTC
bodhi-2.10.1-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2bc58910e7

Comment 8 FrantiĊĦek Zatloukal 2017-09-17 12:17:56 UTC
Fix confirmed on F27. Thanks!

Comment 9 Fedora Update System 2017-09-19 23:23:29 UTC
bodhi-2.10.1-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2017-09-30 06:36:39 UTC
bodhi-2.10.1-4.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.