Bug 1488735

Summary: the unit test "test_schedule_loadbalancer_with_disabled_agent" fails
Product: Red Hat OpenStack Reporter: Arie Bregman <abregman>
Component: openstack-neutron-lbaasAssignee: Nir Magnezi <nmagnezi>
Status: CLOSED ERRATA QA Contact: Ofer Blaut <oblaut>
Severity: high Docs Contact:
Priority: high    
Version: 12.0 (Pike)CC: amuller, apevec, belharar, lhh, nyechiel
Target Milestone: betaKeywords: AutomationBlocker, Triaged
Target Release: 12.0 (Pike)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-neutron-lbaas-11.0.2-0.20170906215706.c43b9a7.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-13 22:02:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Arie Bregman 2017-09-06 07:11:26 UTC
Description of problem:

The following neutron-lbaas RHOSP 12 unit test, fails:

neutron_lbaas.tests.unit.test_agent_scheduler.LBaaSAgentSchedulerTestCase.test_schedule_loadbalancer_with_disabled_agent
neutron_lbaas.tests.unit.drivers.common.test_agent_driver_base.TestLoadBalancerManager.test_schedule_loadbalancer_with_disabled_agent

Version-Release number of selected component (if applicable): osp 12 source


How reproducible: 100%


Steps to Reproduce:
1. clone neutron-lbaas and checkout osp 12 branch
2. run 'tox -e py27'

Actual results:

Traceback (most recent call last):
      File "/home/abregman/dev/neutron-lbaas/.tox/py27/src/neutron/neutron/tests/base.py", line 118, in func
        return f(self, *args, **kwargs)
      File "/home/abregman/dev/neutron-lbaas/.tox/py27/src/neutron/neutron/tests/base.py", line 118, in func
        return f(self, *args, **kwargs)
      File "neutron_lbaas/tests/unit/test_agent_scheduler.py", line 169, in test_schedule_loadbalancer_with_disabled_agent
        self._disable_agent(agents['agents'][0]['id'])
      File "/home/abregman/dev/neutron-lbaas/.tox/py27/src/neutron/neutron/tests/unit/db/test_agentschedulers_db.py", line 216, in _disable_agent
        self._update('agents', agent_id, new_agent)
      File "/home/abregman/dev/neutron-lbaas/.tox/py27/src/neutron/neutron/tests/unit/db/test_db_base_plugin_v2.py", line 554, in _update
        req = self.new_update_request(resource, new_data, id, headers=headers)
    TypeError: new_update_request() got an unexpected keyword argument 'headers'



Expected results: All tests passed successfully

Comment 3 Nir Magnezi 2017-09-06 11:34:17 UTC
This breakage should be resolved by https://review.openstack.org/#/c/484437 , which part of is included in tag 11.0.0.0b3, whereas we currently are at 11.0.0.0b2.

We can either wait for the RDO import or cherry-pick the fix.
Since this is an AutomationBlocker, I chose not to wait and cherry-picked.

Comment 8 errata-xmlrpc 2017-12-13 22:02:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:3462