Bug 1488808

Summary: Warning on FreeBSD regarding -Wformat-extra-args
Product: [Community] GlusterFS Reporter: M. Scherer <mscherer>
Component: buildAssignee: M. Scherer <mscherer>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.13.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-08 17:39:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description M. Scherer 2017-09-06 09:06:09 UTC
Description of problem:
Building on FreeBSD show this warning message:

/tmp/glusterfs/libglusterfs/src/common-utils.c:3763:33: warning: data argument not used by format string [-Wformat-extra-args]
                                "platform");
                                ^
/tmp/glusterfs/libglusterfs/src/logging.h:214:51: note: expanded from macro 'gf_msg'
                        levl, errnum, 0, msgid, ##fmt); 

This is caused by a spurious ',' at the end of the string. The warning only appear on FreeBSD since NetBSD and Linux use a different codepath.

Comment 1 Worker Ant 2017-09-06 09:06:23 UTC
REVIEW: https://review.gluster.org/18214 (Fix warning on FreeBSD, show by -Wformat-extra-args) posted (#1) for review on master by Michael Scherer (misc)

Comment 2 Worker Ant 2017-09-07 09:24:29 UTC
COMMIT: https://review.gluster.org/18214 committed in master by Niels de Vos (ndevos) 
------
commit 6826905213eb7e9bc8728e8269864f066ce0e23a
Author: Michael Scherer <misc>
Date:   Wed Sep 6 11:02:01 2017 +0200

    Fix warning on FreeBSD, show by -Wformat-extra-args
    
    The warning is specific to FreeBSD, since both Linux and NetBSD
    do trigger a different codepath.
    
    Change-Id: I3d2b374b6a39804942af076d7e0d130a76f869a2
    BUG: 1488808
    Signed-off-by: Michael Scherer <misc>
    Reviewed-on: https://review.gluster.org/18214
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Niels de Vos <ndevos>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Shyamsundar 2017-12-08 17:39:41 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/