Bug 1488829

Summary: Fix unused variable when TCP_USER_TIMEOUT is undefined
Product: [Community] GlusterFS Reporter: M. Scherer <mscherer>
Component: buildAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, rgowdapp
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.13.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-08 17:40:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description M. Scherer 2017-09-06 09:47:26 UTC
Description of problem:
-Wunused-variable show a undefined variable in rpc/rpc-transport/socket/src/socket.c

/tmp/glusterfs/rpc/rpc-transport/socket/src/socket.c: In function '__socket_keepalive':
/tmp/glusterfs/rpc/rpc-transport/socket/src/socket.c:846:17: warning: unused variable 'timeout_ms' [-Wunused-variable]
         int     timeout_ms = timeout * 1000;

Comment 1 Worker Ant 2017-09-06 09:47:48 UTC
REVIEW: https://review.gluster.org/18215 (Do not declare the variable timeout_ms if TCP_USER_TIMEOUT is not defined) posted (#1) for review on master by Michael Scherer (misc)

Comment 2 Worker Ant 2017-09-07 17:54:06 UTC
COMMIT: https://review.gluster.org/18215 committed in master by Jeff Darcy (jeff.us) 
------
commit 30712dc7d300fb6bffd45f29d9e9ddd83468f38a
Author: Michael Scherer <misc>
Date:   Wed Sep 6 11:44:06 2017 +0200

    Do not declare the variable timeout_ms if TCP_USER_TIMEOUT is not defined
    
    Trying to fix the build on FreeBSD, -Wunused-variable trigger this warning.
    
    Change-Id: I318121829ac6a609fe9c606aead257827c7748b1
    BUG: 1488829
    Signed-off-by: Michael Scherer <misc>
    Reviewed-on: https://review.gluster.org/18215
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: Michael Scherer <misc>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jeff.us>

Comment 3 Shyamsundar 2017-12-08 17:40:26 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/