Bug 1488840

Summary:	Fix guard define on nl-cache
Product:	[Community] GlusterFS	Reporter:	M. Scherer <mscherer>
Component:	build	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.13.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-08 17:40:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description M. Scherer 2017-09-06 10:13:08 UTC

Description of problem:
Clang complain about the guard define, and seems there was a typo on it:

In file included from /tmp/glusterfs/xlators/performance/nl-cache/src/nl-cache-helper.c:11:
In file included from /tmp/glusterfs/xlators/performance/nl-cache/src/nl-cache.h:14:
/tmp/glusterfs/xlators/performance/nl-cache/src/nl-cache-mem-types.h:12:9: warning: '__NL_CACHe_MEM_TYPES_H__' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]
#ifndef __NL_CACHe_MEM_TYPES_H__

Comment 1 Worker Ant 2017-09-06 10:14:42 UTC

REVIEW: https://review.gluster.org/18216 (Fix the conditional) posted (#1) for review on master by Michael Scherer (misc)

Comment 2 Worker Ant 2017-09-07 17:54:31 UTC

COMMIT: https://review.gluster.org/18216 committed in master by Jeff Darcy (jeff.us) 
------
commit 91cd0ed2a444f868c4cc46a42363d0044294da93
Author: Michael Scherer <misc>
Date:   Wed Sep 6 12:11:09 2017 +0200

    Fix the conditional
    
    Clang complain about it on FreeBSD
    
       In file included from xlators/performance/nl-cache/src/nl-cache-helper.c:11:
       In file included from xlators/performance/nl-cache/src/nl-cache.h:14:
       xlators/performance/nl-cache/src/nl-cache-mem-types.h:12:9: warning: '__NL_CACHe_MEM_TYPES_H__' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]
       #ifndef __NL_CACHe_MEM_TYPES_H__
    
    Change-Id: I4327c7dacf10f2690bd33bf2b37dbb7d9b52bdd5
    BUG: 1488840
    Signed-off-by: Michael Scherer <misc>
    Reviewed-on: https://review.gluster.org/18216
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: Michael Scherer <misc>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jeff.us>

Comment 3 Shyamsundar 2017-12-08 17:40:26 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/