Bug 1489160

Proposed as a Freeze Exception for 27-beta by Fedora user luya using the blocker tracking app because:

 Design team recently sent the wallpaper for beta. The package is ready for review and tested on https://koji.fedoraproject.org/koji/taskinfo?taskID=21693254

I'd rather have a tracker bug that depends on this as the blocker, because just adding the new package is not *all* that needs to happen. https://bugzilla.redhat.com/show_bug.cgi?id=1489164 . Also, this is a blocker, not an FE, because currently F27 images use the F26 backgrounds, and this breaks the release criteria.

Thanks for the correction.

First, thank you to all members of the design team for their great work.

Regarding this package:

 - The Source0 is returning 404: https://releases.pagure.org/design/f27-backgrounds-27.0.0.tar.xz doesn't seem to exist.

 - Similarly, the URL: returns an empty wiki page https://fedoraproject.org/wiki/F27_Artwork

 - There's a mix of spaces and tabs in the SPEC, please choose one only and stick with it. (I prefer spaces).

 - In the source archive, there are a lot of backup files included:

$find f27-backgrounds -iname "*~" 
f27-backgrounds/default/f26.xml~
f27-backgrounds/default/mate-backgrounds-f27.xml~
f27-backgrounds/default/mate-backgrounds-f27-animated.xml~
f27-backgrounds/default/f27.xml~
f27-backgrounds/default/f26-animated.xml~
f27-backgrounds/default/f27-animated-new.xml~
f27-backgrounds/default/f27-animated.xml~
f27-backgrounds/default/Makefile~
f27-backgrounds/default/f27-metadata.desktop.desktop~
f27-backgrounds/default/gnome-backgrounds-f27-animated.xml~
f27-backgrounds/default/gnome-backgrounds-f27.xml~

I think these file are generated as backup by Gedit, I don't think they should be included in the final archive.

Here is the updated spec and srpm files
- Corrected Source0
- Wiki page now exists
- Tab only used
- Removal of "*~" files in sources

Resulted rpmlint:
rpmlint rpmbuild/SRPMS/f27-backgrounds-27.0.0-2.fc26.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Scratch build
https://koji.fedoraproject.org/koji/taskinfo?taskID=21729091

Spec URL: https://luya.fedorapeople.org/packages/SPECS/f27-backgrounds.spec
SRPM URL: https://luya.fedorapeople.org/packages/SRPMS/f27-backgrounds-27.0.0-2.fc26.src.rpm

The requires should be in the form:

Requires: %{name}-base%{_isa} = %{version}-%{release}

You forgot the %{_isa} part.

I accept the 📦 but please fix this before import.

> You forgot the %{_isa} part.

No %{_isa} is required for noarch packages. In fact, it should *not* be there.

Thanks for the review.

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/f27-backgrounds. You may commit to the branch "f27" in about 10 minutes.

f27-backgrounds-27.0.0-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fee0766883

desktop-backgrounds-27.0.0-1.fc27 f27-backgrounds-27.0.0-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fee0766883

desktop-backgrounds-27.0.0-1.fc27, f27-backgrounds-27.0.0-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fee0766883

desktop-backgrounds-27.0.0-1.fc27, f27-backgrounds-27.0.0-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.