Bug 1489339

Summary: glibc: don't rely on downstream modification of hasht.h
Product: [Fedora] Fedora Reporter: Daiki Ueno <dueno>
Component: glibcAssignee: Carlos O'Donell <codonell>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: aoliva, arjun.is, codonell, dj, dueno, fweimer, jakub, law, mfabian, pfrankli, rth, siddhesh, tmraz
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glibc-2.26.90-17.fc28 glibc-2.26-18.fc27 glibc-2.26-20.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-19 19:49:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1113172    
Bug Blocks:    
Attachments:
Description Flags
patch to add -I for nspr none

Description Daiki Ueno 2017-09-07 09:01:55 UTC 
Created attachment 1322986 [details]
patch to add -I for nspr

See bug 1113172 and bug 953277.

Currently, building libcrypt-nss relies on our downstream modification of hasht.h in nss-util package.  We are going to revert it, because the change had caused confusion in other packages using hasht.h.

Once the change is reverted, glibc build will fail due to missing -I pointing to nspr's includedir.  Please consider adjusting glibc build something like the attached patch (not tested).
Comment 1 Daiki Ueno 2017-10-03 08:00:26 UTC 
I have built the nss-util package in rawhide, with this change (nss-util-3.33.0-2.fc28).  I don't plan to port it to other branches so far, but please be aware of the possible FTBFS in rawhide.
Comment 2 Florian Weimer 2017-10-03 10:03:40 UTC 
(In reply to Daiki Ueno from comment #1)
> I have built the nss-util package in rawhide, with this change
> (nss-util-3.33.0-2.fc28).  I don't plan to port it to other branches so far,
> but please be aware of the possible FTBFS in rawhide.

Thanks.  This NSS modification confused me a lot.

Are nss-confiig and nspr-config scripts provided by upstream?  Would it be an improvement to use “nss-config --cflags” instead, which should provide all the necessary include directories for the NSS headers and their dependencies?
Comment 3 Daiki Ueno 2017-10-03 11:08:50 UTC 
Yes, it is provided by the upstream:
https://hg.mozilla.org/projects/nss/file/tip/pkg/pkg-config/nss-config.in

However, I hesitated to change the script as you suggested, because I realized that it does more than querying build flags, for example:

  $ nss-config --includedir=/usr/local/nss3 --cflags
  -I/usr/local/nss3

In my opinion it might make more sense to switch to the pkg-config script, which are also provided by the upstream and pull the necessary dependencies.
Comment 4 Fedora Update System 2017-12-13 12:21:45 UTC 
glibc-2.26-20.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fb5e227432
Comment 5 Fedora Update System 2017-12-14 11:13:53 UTC 
glibc-2.26-20.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fb5e227432
Comment 6 Fedora Update System 2017-12-19 19:49:51 UTC 
glibc-2.26-20.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.