Bug 1489734

Summary: resource agents need to be able to decide if they store per-host or per-bundle attributes
Product: Red Hat Enterprise Linux 7 Reporter: Michele Baldessari <michele>
Component: resource-agentsAssignee: Oyvind Albrigtsen <oalbrigt>
Status: CLOSED ERRATA QA Contact: Udi Shkalim <ushkalim>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 7.4CC: agk, aherr, cfeist, cluster-maint, fdinitto, jherrman, michele, mkrcmari, toneata
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: resource-agents-3.9.5-106.el7 Doc Type: Bug Fix
Doc Text:
Previously, when the rabbit, redis, and galera resource agents were run in a bundle, they used "NODENAME" as the attribute destination. However, "NODENAME" in certain cases pointed to an incorrect destination. With this update, the attribute_target() shell function has been added with support provided to redis, rabbitmq, and galera. As a result, the attribute destination can now be specified, which ensures that the destination is correct.
 Story Points: ---
Clone Of:
: 1493915 (view as bug list) Environment:
Last Closed: 2018-04-10 12:09:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1493915    
Attachments:
Description Flags
ocf_attribute_target patch 1 out of 2
none
Make galera redis rabbit use ocf_attribute_target
none
patch nr1
none
patch 2 none

Description Michele Baldessari 2017-09-08 08:51:21 UTC 
Description of problem:
Currently when we run rabbit/redis/galera within bundle they simply use NODENAME as the destination of attributes. This is problematic because a bundle can move around hosts and so storing an attribute on a per-bundle basis is problematic.

Andrew, Damien and I worked on a fix which lives here:
https://github.com/ClusterLabs/resource-agents/pull/1033

This BZ is to track the release of a fixed package for OSP12

Note that this BZ is partially depending on BZ#1489728 (i.e. the fix is effective only with an updated pcmk, but rabbitmq/redis/galera keep working on baremetal normally without)
Comment 1 Oneata Mircea Teodor 2017-09-08 09:29:05 UTC 
Hello, 
Same issue, please revise the bug according to the zstream documentation, https://mojo.redhat.com/docs/DOC-1021938#jive_content_id_The_workflow
Comment 3 Oneata Mircea Teodor 2017-09-08 11:16:59 UTC 
Same here please add also 7.4z flag
Comment 4 Michele Baldessari 2017-09-11 18:57:38 UTC 
Created attachment 1324542 [details]
ocf_attribute_target patch 1 out of 2
Comment 5 Michele Baldessari 2017-09-11 18:58:15 UTC 
Created attachment 1324543 [details]
Make galera redis rabbit use ocf_attribute_target
Comment 6 Michele Baldessari 2017-09-11 18:59:53 UTC 
Hi Oyvind,

so I attached the two patches that apply downstream (the second one might need -F2 when applying). The 0001 one is a 1-1 of the upstream PR. The second one needed a small massage because galera has changed a bit in master. hth.
Comment 7 Michele Baldessari 2017-09-20 09:50:31 UTC 
Created attachment 1328357 [details]
patch nr1
Comment 8 Michele Baldessari 2017-09-20 09:51:13 UTC 
Created attachment 1328358 [details]
patch 2
Comment 14 errata-xmlrpc 2018-04-10 12:09:28 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0757