Bug 1489973

Summary:	control-pgup and control-pgdn not interpreted correctly
Product:	[Fedora] Fedora EPEL	Reporter:	bill hudacek <bill.hudacek>
Component:	xfce4-terminal	Assignee:	Kevin Fenzi <kevin>
Status:	CLOSED EOL	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	epel7	CC:	f2404, kevin, nonamedotc
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-07-09 15:38:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description bill hudacek 2017-09-08 20:51:15 UTC

Description of problem:

In package xfce4-terminal at version 0.8.6-2, on fedora 25 64-bit, when the option "MiscCycleTabs=FALSE" is set, control-pgdn on the right-most tab should be 'swallowed'.  Instead, the character sequence "^[[6;5~" is sent to the terminal/shell.  On the left-most tab, control-pgup should be swallowed; instead, the character sequence "^[[5;5~" is sent as input to the terminal/shell. 

In version 0.8.5.1-1, this problem is not present. 

Version-Release number of selected component (if applicable):
0.8.6-2

How reproducible:
100%.

Steps to Reproduce:
1. dnf upgrade (at present) automatically installs this latest version
2. Open xfce4-terminal and open more than one tab (I use 6 tabs)
3. with option "MiscCycleTabs=FALSE" in the terminalrc file (~/.config/xfce4/terminal/terminalrc), use control-pgdn and hold down the keys to quickly zip to the right-most tab

Actual results:
The keystrokes appear in the command-line of the shell.

Expected results:
The keystrokes are silently 'swallowed' by xfce4-terminal and do not get sent as input to the shell.

Additional info:
Downgrading to 0.8.5.1-1 is a workaround for now.

Comment 1 Kevin Fenzi 2017-09-09 18:31:26 UTC

Would you be willing to file this upstream at bugzilla.xfce.org?

Or if you like I can do so...

Comment 2 bill hudacek 2017-09-11 12:28:12 UTC

Either way.  My googling didn't find much outside of this bugzilla for 'xfce4-terminal bugs' (aside from debian :-).

Can you do it? Is there some way to tie the two together? That's beyond me as I write this......

Comment 3 Kevin Fenzi 2017-09-16 23:02:09 UTC

https://bugzilla.xfce.org/show_bug.cgi?id=13862

Comment 4 Igor 2017-09-17 01:42:18 UTC

Hi bill, I'm the current xfce4-terminal developer.

The problem with the versions prior to 0.8.6 was that they always swallowed Ctrl+PgUp/Dn shortcuts, including your case and even single tab case. That impacted some console apps, e.g. mc: it uses Ctrl+PgUp for opening archives, and it just didn't work.
So I went ahead and changed the code to swallow those shortcuts only in cases when they are used for tabs switching. Now, when you disable tabs cycling and reach the first or the last tab, the corresponding shortcut becomes inactive (you can check that by looking at the menu). Which, in turn, disables swallowing and makes the symbols to be printed into the terminal.

To me, such behavior seems pretty consistent as it's the same for the single tab case and first or last tabs with tabs cycling disabled. In all those cases, the shortcuts in the menu are disabled, and Ctrl+PgUp/Dn are passed to the client (or printed if there's no app running).

Comment 5 Igor 2017-10-02 13:20:16 UTC

Hi, any response?

Comment 6 bill hudacek 2017-10-02 21:06:38 UTC

Hi, Igor. Sorry, had a very rough few weeks here. First, thanks for your thoughtful reply. I've had bug reports that just sit for *years* with no response :-)

I understand your use case. It makes mc 'workable' when it's in the last tab (control-pgdn now goes to mc), and in the first tab (control-pgup now goes to mc), but I don't see how mc can get both pgup and pgdn in the terminal window. Is this really workable?

My use case, on the other hand, is this: I work lightning-fast, in this way. I have 6 tabs open, all the time, in a terminal when I'm logged in. I can be on tab two (working notes for 'this year'), or tab 5 (my generated PDF files for stuff I archive from email and the web). If I'm on tab 3, I don't need to notice how many tabs to jump to PDFs...I just repeat control-pgdn for about 1.5 seconds, and then hit control-pgup once. See what I mean?

Now, with 8.6, the escape characters from the terminfo entry start to appear on the command-line. If I don't notice it, then I enter 'df' or some such and get command not found (of course). If I do notice it, I have to hold down bksp for a couple of seconds to wipe them out.

It's not a serious challenge, but boy is it annoying. I'm just that insane about 'productivity', is all.

If it's going to be there as a 'feature', I'll have to figure out another way to work or just get used to it.

But if no one is really benefiting from having half of the pgup/pgdn keys working on the first/last tabs, then why do it that way? :-)

Thanks again. Among all the terminals I've used, this is the one I set up no matter which desktop env I'm using. The only thing missing is control+ to enlarge text and control-- to reduce it - but gnome-terminal does terribly at this.

Comment 7 Troy Dawson 2024-07-09 15:38:16 UTC

EPEL 7 entered end-of-life (EOL) status on 2024-06-30.  EPEL 7 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug.