Bug 1490311

The container does not expose any port?

I missed help.1 or help.md page which describes the container.

The README does not contain the same information like is mentioned in LABEL.run.
This should be documented in READMEm how to run the container.

Any reason why io.k8s.{discription|display-name} and io.openshift{tags|expose-services} are not used?

If it is not system-container, why there are not used atomic install labels like is mentioned here https://fedoraproject.org/wiki/Container:Guidelines#LABELS.
Even the LABELs are optional.

I miss label help which is described here https://fedoraproject.org/wiki/Container:Guidelines#LABEL_SPECIFICATION.

Can you please update the container for using distgen?

I tried to run the container but fails.
~~~
atomic run modularitycontainers/tools
Need to pull modularitycontainers/tools
Unable to find modularitycontainers/tools
make: *** [Makefile:11: run] Error 1
~~~

Please fix issues.

(In reply to Petr Hracek from comment #1)
> The container does not expose any port?

It does not, it's just a collection of binaries.

> I missed help.1 or help.md page which describes the container.

I did not know what would I write in there: so I'll just list all available executables.

> The README does not contain the same information like is mentioned in
> LABEL.run.
> This should be documented in READMEm how to run the container.

It is: `atomic run $the_image`

> Any reason why io.k8s.{discription|display-name} and
> io.openshift{tags|expose-services} are not used?

Because they are not required by Fedora: https://fedoraproject.org/wiki/Container:Guidelines#LABELS

> If it is not system-container, why there are not used atomic install labels
> like is mentioned here
> https://fedoraproject.org/wiki/Container:Guidelines#LABELS.
> Even the LABELs are optional.

Because there is nothing to install.

> I miss label help which is described here
> https://fedoraproject.org/wiki/Container:Guidelines#LABEL_SPECIFICATION.

I'll do help files instead.

> Can you please update the container for using distgen?

No I can't -- there is nothing to template.

> I tried to run the container but fails.
> ~~~
> atomic run modularitycontainers/tools
> Need to pull modularitycontainers/tools
> Unable to find modularitycontainers/tools
> make: *** [Makefile:11: run] Error 1
> ~~~

You need to build it first.

> Please fix issues.

(In reply to Tomas Tomecek from comment #2)
> (In reply to Petr Hracek from comment #1)
> > The container does not expose any port?
> 
> It does not, it's just a collection of binaries.
> 
> > I missed help.1 or help.md page which describes the container.
> 
> I did not know what would I write in there: so I'll just list all available
> executables.
> 
> > The README does not contain the same information like is mentioned in
> > LABEL.run.
> > This should be documented in READMEm how to run the container.
> 
> It is: `atomic run $the_image`
Sorry I will rephrase it a bit. What about for case if user wants to run it via docker and atomic. I guess, in README would be something like

In case of using docker binary run container by command:
docker run -v /run:/run -v /var/log:/var/log -v /etc/machine-id:/etc/machine-id -v /etc/localtime:/etc/localtime -v /:/host IMAGE


> 
> > Any reason why io.k8s.{discription|display-name} and
> > io.openshift{tags|expose-services} are not used?
> 
> Because they are not required by Fedora:
> https://fedoraproject.org/wiki/Container:Guidelines#LABELS
> 
> > If it is not system-container, why there are not used atomic install labels
> > like is mentioned here
> > https://fedoraproject.org/wiki/Container:Guidelines#LABELS.
> > Even the LABELs are optional.
> 
> Because there is nothing to install.
> 
> > I miss label help which is described here
> > https://fedoraproject.org/wiki/Container:Guidelines#LABEL_SPECIFICATION.
> 
> I'll do help files instead.
> 
> > Can you please update the container for using distgen?
> 
> No I can't -- there is nothing to template.
> 
> > I tried to run the container but fails.
> > ~~~
> > atomic run modularitycontainers/tools
> > Need to pull modularitycontainers/tools
> > Unable to find modularitycontainers/tools
> > make: *** [Makefile:11: run] Error 1
> > ~~~
> 
> You need to build it first.
> 
What about to add dependency run into build in Makefile?

> > Please fix issues.

(In reply to Petr Hracek from comment #3)
> Sorry I will rephrase it a bit. What about for case if user wants to run it
> via docker and atomic. I guess, in README would be something like
> 
> In case of using docker binary run container by command:
> docker run -v /run:/run -v /var/log:/var/log -v
> /etc/machine-id:/etc/machine-id -v /etc/localtime:/etc/localtime -v /:/host
> IMAGE

I don't want to personally support a use case, when users run it via docker binary -- a simple typo in the loooooong commandline may easily result into malfunction.


> > You need to build it first.
> > 
> What about to add dependency run into build in Makefile?

Would you be okay with rebuilding the image every time you want to run it? I would personally not. Will add a line for this into README.

I think I addressed all the issues, updated build context: https://github.com/TomasTomecek/tools/archive/a65d093f6e4e74c5fdae87c94933b1b137f04731.zip

(or use master branch of my fork: https://github.com/TomasTomecek/tools)

The container tools seems to be fine from my point of view.

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/container/tools

Petr, thank for review!

The build is done:

  candidate-registry.fedoraproject.org/f26/tools:rawhide-container-candidate-68735-20170912140601
  candidate-registry.fedoraproject.org/f26/tools:0-1.f26container
  candidate-registry.fedoraproject.org/f26/tools:0
  candidate-registry.fedoraproject.org/f26/tools:latest