Bug 1491171

Created attachment 1325276 [details]
/etc/sysconfig/docker file before and after metrics is deployed

Blocks all metrics installation.

The error message doesn't have anything to do with metrics components but an issue with the registry installation. I am re-assigning this to the installer component.

Junqi,

I believe based on the description you set them in /etc/sysconfig/docker manually?

In general the installer manages the list of additional, insecure, and blocked registries so you'll want to set variables like the following in your inventory.

openshift_docker_additional_registries=registry.ops.openshift.com
openshift_docker_insecure_registries=registry.ops.openshift.com

I recognize that this may odd that docker configuration may be applied while calling the metrics installation playbooks but the role dependencies today are such that we ensure that docker is configured properly no matter which playbook you call so we need to make sure that proper inventory variables are set in all cases.

Does that help?

(In reply to Scott Dodson from comment #4)
> Junqi,
> 
> I believe based on the description you set them in /etc/sysconfig/docker
> manually?
  No, I did not set it manually, 
> In general the installer manages the list of additional, insecure, and
> blocked registries so you'll want to set variables like the following in
> your inventory.
> 
> openshift_docker_additional_registries=registry.ops.openshift.com
> openshift_docker_insecure_registries=registry.ops.openshift.com

I used template to build my jobs:
http://git.app.eng.bos.redhat.com/git/openshift-misc.git/plain/v3-launch-templates/functionality-testing/aos-37/vars-gce/vars.ose37-container-ah7-gcs_registry-gce-cloudprovider

registry.ops.openshift.com already in openshift_docker_additional_registries and 
openshift_docker_insecure_registries

After OCP was built successfully, I checked "--add-registry registry.ops.openshift.com" is in ADD_REGISTRY from /etc/sysconfig/docker
, but when I deployed metrics via ansible, it removed from ADD_REGISTRY, I think  it's related to metrics playbooks.

I checked logs in the attached file "ansible running log", and found the following, do you think
("line": "ADD_REGISTRY='--add-registry registry.access.redhat.com') is the cause?
    "invocation": {
        "module_args": {
            "attributes": null, 
            "backrefs": false, 
            "backup": false, 
            "content": null, 
            "create": false, 
            "delimiter": null, 
            "dest": "/etc/sysconfig/docker", 
            "directory_mode": null, 
            "follow": false, 
            "force": null, 
            "group": null, 
            "insertafter": null, 
            "insertbefore": null, 
            "line": "ADD_REGISTRY='--add-registry registry.access.redhat.com'", 
            "mode": null, 
            "owner": null, 
            "path": "/etc/sysconfig/docker", 
            "regexp": "^ADD_REGISTRY=.*$", 
            "remote_src": null, 
            "selevel": null, 
            "serole": null, 
            "setype": null, 
            "seuser": null, 
            "src": null, 
            "state": "present", 
            "unsafe_writes": null, 
            "validate": null
        }

same error with logging, attached journal logs

Created attachment 1325703 [details]
journal log

I can confirm that openshift_docker_additional_registries works as previous.

openshift_docker_additional_registries must be specified each time you run plays.  It appears that the lack of this variable inside your inventory has caused the registry to be removed, which is expected current behavior.

From OCP 3.7, we should add openshift_docker_additional_registries in inventory file, otherwise it will throw out error like this defect reported.

Added this parameter in inventory, and logging and metrics installation were successful.

Close it as NOTABUG.