Bug 1492065

(In reply to Lucie Leistnerova from comment #0)
> Description of problem:
> Upgrading dwh from 4.1 to 4.2 fails with Internal error: type object
> 'Stages' has no attribute 'DB_CUST_UPGRADEDBMS_DWH'
> 
> 
> Version-Release number of selected component (if applicable):
> ovirt-engine-dwh-setup-4.1.1-1.el7.centos.noarch
> ovirt-engine-dwh-setup-4.2.1-0.0.master.20170912085356.el7.centos.noarch
> 
> How reproducible: always
> 
> 
> Steps to Reproduce:
> 1. have DWH 4.1 installed and running on separate machine
> 2. install 4.2 master repo
> 3. yum update ovirt-engine-dwh-setup

Is this copied from our documentation?

You should update all relevant machines, just as in updating the engine. See also e.g. bug 1306212.

That said, we *can* "fix" current bug, but it will require on-going maintenance which I am not sure is worth it, by changing the dwh spec file from having, under '%package setup':

Requires:       ovirt-engine-setup-plugin-ovirt-engine-common

To:

Requires:       ovirt-engine-setup-plugin-ovirt-engine-common >= 4.2.0

(and then >= 4.3 on the next version, etc.).

Most likely we had similar issues in previous versions - we have this line since 3.4, and so far handled this only using documentation.

> 4. run engine-setup
> 
> Actual results: # engine-setup 
> ***L:ERROR Internal error: type object 'Stages' has no attribute
> 'DB_CUST_UPGRADEDBMS_DWH'
> 
> 
> Expected results: no error, dwh is upgraded
> 
> 
> Additional info:

Sandro, feel free to ack anyway, might be worth it even if docs are correct.

To run 'yum update ovirt-engine-dwh-setup' told me the engine-setup.
When I updated 'yum update ovirt-engine*setup*' this error is gone and other appears 

***L:ERROR Internal error: Internal error, plugins set(['otopi', 'ovirt-engine-setup', 'ovirt-engine-checks', 'ovirt-engine-common']) are missing

yum info:

Updating:
 ovirt-engine-setup-base
 ovirt-engine-setup-plugin-ovirt-engine-common
Updating for dependencies:
 otopi
 ovirt-engine-lib

(In reply to Lucie Leistnerova from comment #3)
> To run 'yum update ovirt-engine-dwh-setup' told me the engine-setup.

I think it should have told you to update also ovirt-engine-setup, no?

Please attach all setup logs, yum log, and used repos. Thanks.

> When I updated 'yum update ovirt-engine*setup*' this error is gone and other
> appears 
> 
> ***L:ERROR Internal error: Internal error, plugins set(['otopi',
> 'ovirt-engine-setup', 'ovirt-engine-checks', 'ovirt-engine-common']) are
> missing

That's bug 1484961.

> 
> yum info:
> 
> Updating:
>  ovirt-engine-setup-base
>  ovirt-engine-setup-plugin-ovirt-engine-common
> Updating for dependencies:
>  otopi
>  ovirt-engine-lib

(In reply to Yedidyah Bar David from comment #4)
> (In reply to Lucie Leistnerova from comment #3)
> > To run 'yum update ovirt-engine-dwh-setup' told me the engine-setup.
> 
> I think it should have told you to update also ovirt-engine-setup, no?
> 
> Please attach all setup logs, yum log, and used repos. Thanks.
> 

According to documentation DWH on separate machine needs only ovirt-engine-dwh-setup package and its dependencies.
When I installed ovirt-release-master.rpm (4.1 dwh already running) engine-setup fails with:

[ INFO  ] Checking for an update for Setup...
          An update for the Setup packages ovirt-engine-dwh-setup was found. Please update that package by running:
          "yum update ovirt-engine-dwh-setup"
          and then execute Setup again.
[ ERROR ] Failed to execute stage 'Environment customization': Please update the Setup packages

So no ovirt-engine-setup.

Created attachment 1327358 [details]
logs

Upgrade was successful 

verified in ovirt-engine-dwh-4.2.1-0.2.master.20171026133424.el7.centos.noarch

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.