Bug 1492150

Summary:	setting a dynamic dialog to "required = True" is not saved
Product:	Red Hat CloudForms Management Engine	Reporter:	Felix Dewaleyne <fdewaley>
Component:	Provisioning	Assignee:	eclarizi
Status:	CLOSED CURRENTRELEASE	QA Contact:	Shveta <sshveta>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.8.0	CC:	ealcaniz, fdewaley, gmccullo, jhardy, obarenbo, simaishi, smallamp
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.9.0
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	5.9.0.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1495971 1496946 (view as bug list)		Environment:
Last Closed:	2018-03-06 14:45:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1495971, 1496946

Description Felix Dewaleyne 2017-09-15 15:27:13 UTC

Description of problem:
setting a dynamic dialog to "required = True" is not saved

Version-Release number of selected component (if applicable):
5.8.1.5

How reproducible:
all the time

Steps to Reproduce:
1.create a service dialog
2.set a dynamic list menu item to "required = true"
3.save
4.edit the dialog again

Actual results:
the setting has clearly not been saved and is set again to "required = false"

Expected results:
if this value is only expected to be handled through automation it should be removed from the dialog, otherwise the value should save

Additional info:
reproduced in lab

Comment 3 CFME Bot 2017-09-18 22:28:54 UTC

https://github.com/ManageIQ/manageiq-ui-classic/pull/2185

Comment 4 CFME Bot 2017-09-18 23:43:45 UTC

New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/de41bb4ae1cac60ca462249009e36c736fe0a371

commit de41bb4ae1cac60ca462249009e36c736fe0a371
Author:     Erik Clarizio <eclarizio>
AuthorDate: Mon Sep 18 15:15:12 2017 -0700
Commit:     Erik Clarizio <eclarizio>
CommitDate: Mon Sep 18 15:15:12 2017 -0700

    Ensure the 'required' property gets saved for dynamic drop down fields
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1492150

 app/controllers/miq_ae_customization_controller/dialogs.rb  |  1 +
 .../_dialog_field_form_dynamic_options.html.haml            | 13 ++++---------
 .../_dialog_field_form_non_dynamic_options.html.haml        | 11 +++--------
 3 files changed, 8 insertions(+), 17 deletions(-)

Comment 7 CFME Bot 2017-10-09 16:23:28 UTC

New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/cc4048ec15efa7c5f50dd63931a9479e3f336622

commit cc4048ec15efa7c5f50dd63931a9479e3f336622
Author:     Erik Clarizio <eclarizio>
AuthorDate: Thu Oct 5 12:17:32 2017 -0700
Commit:     Erik Clarizio <eclarizio>
CommitDate: Thu Oct 5 12:17:32 2017 -0700

    Allow required flag to be set/unset for all field types
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1492150

 app/controllers/miq_ae_customization_controller/dialogs.rb | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

Comment 8 Shveta 2018-01-16 22:45:11 UTC

Fixed in 5.9.0.16.20180109204148_7ac9852