Bug 1492361

Summary:	Custom Button does not display for Dashboard View of a Provider
Product:	Red Hat CloudForms Management Engine	Reporter:	myoder
Component:	UI - OPS	Assignee:	Harpreet Kataria <hkataria>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Yadnyawalk Tale <ytale>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.8.0	CC:	akarol, dajohnso, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.9.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1496925 (view as bug list)		Environment:
Last Closed:	2018-03-06 15:35:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1496925

Description myoder 2017-09-16 21:11:23 UTC

Description of problem:
When navigating to the Dashboard view of a provider, Custom Buttons are not being displayed in the UI.  Custom Buttons can be seen when using the Summary view of a provider.

This issue was discovered with the VMware Infrastructure Provider.

Version-Release number of selected component (if applicable):
CFME 5.8.1.5
VMware

How reproducible:
Every time

Steps to Reproduce:
1. add a new VMware provider
2. create a custom button under the Provider accordion heading
3. toggle between Summary and Dashboard view of the VMware provider

Actual results:
Buttons display only with Summary view

Expected results:
Buttons should display in both Summary and Dashboard view

Additional info:
Will be providing IP of a local appliance, and photos shortly.

Comment 6 Harpreet Kataria 2017-09-21 20:14:28 UTC

https://github.com/ManageIQ/manageiq-ui-classic/pull/2212

Comment 7 CFME Bot 2017-09-22 08:19:58 UTC

New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/90488176fed63b6a4e3b43fda83830e71f40fde8

commit 90488176fed63b6a4e3b43fda83830e71f40fde8
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Sep 21 16:06:35 2017 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Sep 21 16:06:35 2017 -0400

    Fixed code to render custom buttons toolbar on provider dashboard view
    
    Fixed code to render custom buttons toolbar when switching Textual summary to Dashboard view for a selected Provider
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1492361

 app/controllers/mixins/custom_buttons.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 10 Aziza Karol 2017-12-26 13:37:11 UTC

ytale please test this asap

Comment 11 Yadnyawalk Tale 2017-12-28 13:28:55 UTC

Created attachment 1373205 [details]
verified_custom_button

Custom button displaying on both Summary and Dashboard view as expected.
Verified on: 5.9.0.14.20171219165537_e3dea29

Thanks!

Comment 12 Yadnyawalk Tale 2017-12-28 13:55:28 UTC

+Update: Tested on vCenter (5, 6 and 65-nested), SCVMM (ms-scvmm, scvmm2016) and Red Hat Virtulization (rhv41) providers.