Bug 1492723

Summary: MAC address can be used after vNIC unplug - NO duplication is allowed in the cluster
Product: [oVirt] ovirt-engine Reporter: Michael Burman <mburman>
Component: BLL.NetworkAssignee: Martin Mucha <mmucha>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 4.2.0CC: bugs, danken
Target Milestone: ovirt-4.1.7Keywords: Regression
Target Release: 4.1.7.3Flags: rule-engine: ovirt-4.1+
rule-engine: ovirt-4.2+
rule-engine: blocker+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: error in refactoring, not expected flow in code. Consequence: mac address was released as part of nic unplug. Fix: we do not release mac address during unplug as we did before refactor.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-13 12:28:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1435485    
Attachments:
Description Flags
engine log none

Description Michael Burman 2017-09-18 14:19:03 UTC
Created attachment 1327474 [details]
engine log

Description of problem:
MAC address can be used after vNIC unplug - NO duplication is allowed in the cluster.

It is possible to assign a MAC address after unplugging the vNIC from the VM(no duplication is allowed in the cluster), although it should be considered as in use. The MAC address should be released only on vNIC remove. 

This is a new regression.

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.0-0.0.master.20170917124606.gita804ef7.el7.centos.noarch

How reproducible:
100

Steps to Reproduce:
1. RUN VM with 1 vNIC in cluster with no duplication allowed
2. Unplug the vNIC
3. Assign the VM's MAC address to another VM

Actual results:
It is possible to assign the MAC address to another VM.

Expected results:
Should fail with MAC address already in use error.

Comment 1 Red Hat Bugzilla Rules Engine 2017-09-18 19:27:05 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 2 Michael Burman 2017-09-27 14:18:39 UTC
Verified on - 4.2.0-0.0.master.20170926175518.git0d20200.el7.centos

Comment 3 Sandro Bonazzola 2017-10-10 12:23:44 UTC
(In reply to Michael Burman from comment #2)
> Verified on - 4.2.0-0.0.master.20170926175518.git0d20200.el7.centos

This bug is targeted to 4.1.7, please verify on 4.1.7

Comment 4 Michael Burman 2017-10-15 08:07:26 UTC
Verified on -  4.1.7.3-0.1.el7