Bug 149278

Summary:	gfs_fsck: enter after prompt without a "y" or "n" hangs
Product:	[Retired] Red Hat Cluster Suite	Reporter:	Corey Marthaler <cmarthal>
Component:	gfs	Assignee:	AJ Lewis <157070.alewis>
Status:	CLOSED CURRENTRELEASE	QA Contact:	GFS Bugs <gfs-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4
Target Milestone:	---
Target Release:	---
Hardware:	i686
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-02-23 23:33:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Corey Marthaler 2005-02-21 21:46:05 UTC

Description of problem:
I ran with super verbose to make sure it was actually stuck:

ondisk and fsck bitmaps differ at block 1407
(pass5.c:199)   Ondisk is 2 - FSCK thinks it is 0 (13)
Fix bitmap for block 1407? (y/n) y
(rgrp.c:135)    rgrp already read...
(bio.c:140)     Writing to 69632 - 17 4096
(rgrp.c:179)    rgrp still held...
Suceeded.
ondisk and fsck bitmaps differ at block 1408
(pass5.c:199)   Ondisk is 2 - FSCK thinks it is 0 (13)
Fix bitmap for block 1408? (y/n) y
(rgrp.c:135)    rgrp already read...
(bio.c:140)     Writing to 69632 - 17 4096
(rgrp.c:179)    rgrp still held...
Suceeded.
ondisk and fsck bitmaps differ at block 1409
(pass5.c:199)   Ondisk is 2 - FSCK thinks it is 0 (13)
Fix bitmap for block 1409? (y/n) y
(rgrp.c:135)    rgrp already read...
(bio.c:140)     Writing to 69632 - 17 4096
(rgrp.c:179)    rgrp still held...
Suceeded.
ondisk and fsck bitmaps differ at block 1410
(pass5.c:199)   Ondisk is 2 - FSCK thinks it is 0 (13)
Fix bitmap for block 1410? (y/n)

I just hit enter and... hang-o



Version-Release number of selected component (if applicable):
GFS 2.6.9-23.1 (built Feb 17 2005 11:51:12) installed


How reproducible:
Always

Comment 1 Derek Anderson 2005-02-22 14:31:32 UTC

Well, it's not technically hanging, it's waiting for a char and then 
a return.  Try pressing "y" then Enter. 
 
So it's still a bug, but a UI bug, not a hang.

Comment 2 AJ Lewis 2005-02-22 17:26:58 UTC

I don't consider this a bug.  There is no obvious default to the query, so it's
waiting for the user to specify one.  I suppose I could have the fsck ask the
question again if no character is specified...is that what you're expecting?

Comment 3 Corey Marthaler 2005-02-22 17:33:16 UTC

yes. I would like to see the question again. :)

Comment 4 AJ Lewis 2005-02-22 22:05:50 UTC

Fixed to reprompt on carriage return or invalid response.  Should be in next build.

Comment 5 Corey Marthaler 2005-02-23 23:33:55 UTC

fix verified.