Bug 1493166

Summary:	gluster volume asks for confirmation for disperse volume even with force
Product:	[Community] GlusterFS	Reporter:	Zdenek Styblik <zdenek.styblik>
Component:	cli	Assignee:	bugs <bugs>
Status:	CLOSED EOL	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.11	CC:	amukherj, bugs, ksubrahm
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1493893 (view as bug list)		Environment:
Last Closed:	2017-10-09 07:23:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1493893
Bug Blocks:

Description Zdenek Styblik 2017-09-19 13:56:26 UTC

Description of problem:

When creating dispersed volume, replica 2, cli asks for confirmation even when force is give. This is a breaking change as it used to work before and even without force, although I cannot confirm this, because we don't have 3.4 anymore.


Version-Release number of selected component (if applicable):

Debian Jessie 3.11.3-2

How reproducible:

Every time/easy.


Steps to Reproduce:

gluster volume create myvolume replica 2 transport tcp host01.example.com:/brick/myvolume host02.example.com:/brick/myvolume force
Replica 2 volumes are prone to split-brain. Use Arbiter or Replica 3 to avoid this. See:  https://gluster.readthedocs.io/en/latest/Administrator%20Guide/Split%20brain%20and%20ways%20to%20deal%20with%20it/.
Do you still want to continue?
 (y/n)

Actual results:

GlusterFS volume not created.

Expected results:

GlusterFS volume is created at least when force is given.

Additional info:

Breaking change which breaks tooling built around cli.

Comment 1 Atin Mukherjee 2017-09-20 04:27:41 UTC

Please note that the command you have mentioned here refers to creating a replica 2 volume (not disperse one) and that's the expected behavior. We encourage users to use arbiter or replica 3 volumes instead of replica 2 and this confirmation is in place even with a force option.

Comment 2 Zdenek Styblik 2017-09-20 04:42:30 UTC

(In reply to Atin Mukherjee from comment #1)
> Please note that the command you have mentioned here refers to creating a
> replica 2 volume (not disperse one) and that's the expected behavior. We
> encourage users to use arbiter or replica 3 volumes instead of replica 2 and
> this confirmation is in place even with a force option.

I'm sorry, but WHAT? Alright, I understand I got terminology mixed up, but you what? Are you serious? It kind of feels like #NotABugFeature to me.

Let me repeat. You've broken backwards compatibility of CLI **EVEN** when force is provided. Since you want to encourage users, why not to document it or just a print notification and link to documentation. But to add confirmation which 1. wasn't there before and breaks stuff 2. which appears even with force makes no sense to me.

Have a good day.

Comment 3 Atin Mukherjee 2017-09-20 08:26:57 UTC

I think your concern is valid. I'm passing down this issue to the author of the patch, Karthick. Ideally the force option should bypass this validation.

@Karthick - Would you send a patch for the same?

Comment 4 Karthik U S 2017-10-09 07:23:44 UTC

BZ #1495858 is filed against the maintained version and the fix is also sent for this. You should get this fixed in 3.12 with the next update of that.