Bug 149362

Summary: 3 * array subscript out of range
Product: [Fedora] Fedora Reporter: David Binderman <dcb314>
Component: abeAssignee: Panu Matilainen <pmatilai>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 3   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-07-01 21:05:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Binderman 2005-02-22 17:30:39 UTC
Description of problem:

I just tried to compile package abe-1.0-3 from 
Redhat Fedora Extras development tree.

The compiler said

1.

src/Image.c(125): warning #175: subscript out of range

The source code is

          img_gem[2] = image_count;

but, earlier in the same file,

int img_balloon[3], img_gem[2], img_bullet[4], img_slide_left[3],
img_slide_right[3], img_slideback;

Suggest code rework.

2.

src/Menu.c(105): warning #1011: missing return statement at end of
non-void function "isEnabled"

The source code is

int isEnabled(int n) {
  if(n == SOUND_ENABLED || n == MUSIC_ENABLED)
        return sound_loaded;
}

Suggest add statement for the else case.

3.

src/Game.c(538): warning #175: subscript out of range
src/Game.c(552): warning #175: subscript out of range

Duplicates.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Panu Matilainen 2005-04-11 16:25:58 UTC
This should take care of these warnings and also fixes build with gcc4:
http://fedora.laiskiainen.org/SRPMS.extras/abe-1.0-5.src.rpm

If somebody with cvs-access cares to import...

Comment 2 Michael Schwendt 2005-04-12 14:39:55 UTC
Panu, probably nobody will notice import requests in bugzilla unless you add
somebody via "Cc". I don't know who else does random "changes in last 14 days"
queries and only then stumbles into tickets like this.

Anyway, imported above package into devel tree.


Comment 3 Michael Schwendt 2005-07-01 21:05:10 UTC
Fixed in FE4, abe-1.0-5.