Bug 1493760

Summary:	go-colorable import path points to gopkg.in instead of github.com
Product:	[Fedora] Fedora	Reporter:	Ed Marshall <esm>
Component:	golang-github-mattn-go-colorable	Assignee:	Matthias Runge <mrunge>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	mrunge
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc26	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-10-04 22:21:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1430146

Description Ed Marshall 2017-09-20 20:39:09 UTC

According to the installation instructions at https://github.com/mattn/go-colorable the correct import path for go-colorable is:

github.com/mattn/go-colorable

But, the spec for the Fedora package only provides

gopkg.in/mattn/go-colorable.v1

This doesn't appear to be a valid import path at all (only v0 actually works, because of the available tags on the repository; try to "go get" that URL, and you'll see what I mean), and isn't referenced anywhere in the documentation.

It looks like this was added during package review, but the external expectation for the import path seems to be the github URL; see https://github.com/mgutz/ansi/blob/master/print.go as an example of this in the wild.

Comment 1 Fedora Update System 2017-09-21 06:50:40 UTC

golang-github-mattn-go-colorable-0-0.4.20170816gitad5389d.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-bf5e7f8700

Comment 2 Matthias Runge 2017-09-21 06:51:50 UTC

I'm very sorry about this, it seems it slipped through. I've pushed fixes for all fedora releases

Comment 3 Fedora Update System 2017-09-22 05:53:19 UTC

golang-github-mattn-go-colorable-0-0.4.20170816gitad5389d.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-bf5e7f8700

Comment 4 Fedora Update System 2017-09-22 08:39:22 UTC

golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1767a27810

Comment 5 Fedora Update System 2017-09-23 00:28:05 UTC

golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1767a27810

Comment 6 Fedora Update System 2017-10-04 22:21:30 UTC

golang-github-mattn-go-colorable-0-0.5.20170816gitad5389d.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.