Bug 1493914

Summary: ISCSI targets results in duplicate connections with incorrect node.tpgt values.
Product: Red Hat Enterprise Virtualization Manager Reporter: Ribu Tho <rabraham>
Component: ovirt-engineAssignee: Maor <mlipchuk>
Status: CLOSED ERRATA QA Contact: Avihai <aefrat>
Severity: high Docs Contact:
Priority: high    
Version: 4.1.4CC: adevolder, gveitmic, ldigby, lsurette, lveyde, mkalinin, mlipchuk, rbalakri, Rhev-m-bugs, srevivo, tnisan, ycui, ykaul, ylavi
Target Milestone: ovirt-4.2.1Flags: lsvaty: testing_plan_complete-
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: vdsm v4.20.13 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-15 17:45:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
iscsi_dialog
none
iscsi_dialog2
none
iscsi_dialog_2 none

Description Ribu Tho 2017-09-21 07:21:00 UTC
Description of problem:

Adding  ISCSI LUN's  via GUI creates target files under host directory with incorrect node.tpgt values. Later creates an entry for the original LUN ID and ends up with duplicate logins to the same ISCSI targets. 

Version-Release number of selected component (if applicable):

vdsm-4.19.28-1.el7ev.x86_64
iscsi-initiator-utils-6.2.0.874-4.el7.x86_64


How reproducible:

* Try to attach a direct LUN via ISCSI having LUN ID different to 1 from the RHV GUI and you end up with a default file under /var/lib/iscsi/nodes/*****/default that has the value as node.tpgt as 1.

Steps to Reproduce:

1. Use a target with LUN ID different from 1 for example as follows 
   
# iscsiadm -m session  
tcp: [166] 192.168.xx.xx:3260,2460 iqn.2007-11.com.xxxxxxxxx:xxxxxxxxxxxxxxxxxxxxxxxxx (non-flash)
                              ^^^^^

2. Add the disk as direct LUN via  RHV GUI for a VM with discovery and logging in. 

3. This creates a file under /var/lib/iscsi/nodes/xxxxxxx/default for as follows

drw-------. 2 root root 4096 Sep 20 13:42 192.168.xx.xx,3260,1


4.1  Starting/Migrating  the VM from host A to Host B and migrating back to A  ends up with another file for 

drw-------. 2 root root 4096 Sep 20 13:42 192.168.xx.xx,3260,2460

4.2 Shutting down the VM and doing a manual discovery and login creates another 2460 file resulting in multiple connections onto the host. 

Actual results:

* Creates a stale file for node.tpgt =1 
* Ends up with duplicate logins to the same target with node.tpgt =1 and node.tpgt = (original_hardware number) . eg : 2460 for Nimble Storage CS1000 

Expected results:

* Login to an ISCSI target with correct LUN number showing up on node.tpgt .

Additional info:

Comment 12 Maor 2017-12-13 13:29:01 UTC
Added also the GUI fix.
Yaniv, do you see any reason we should reflect the portal in the iSCSI pop up dialog (attached print screen)?

Comment 13 Maor 2017-12-13 13:29:37 UTC
Created attachment 1367355 [details]
iscsi_dialog

Comment 14 Maor 2017-12-13 13:30:06 UTC
Created attachment 1367356 [details]
iscsi_dialog2

Comment 15 Maor 2017-12-13 13:31:18 UTC
Created attachment 1367357 [details]
iscsi_dialog_2

Comment 16 Yaniv Lavi 2017-12-18 12:15:55 UTC
(In reply to Maor from comment #12)
> Added also the GUI fix.
> Yaniv, do you see any reason we should reflect the portal in the iSCSI pop
> up dialog (attached print screen)?

Nice to have in my POV.

Comment 17 Maor 2017-12-18 12:23:30 UTC
I will open a separate bug on that to get the UX opinion

Comment 18 RHV bug bot 2018-01-05 16:58:45 UTC
INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Project 'ovirt-engine'/Component 'vdsm' mismatch]

For more info please contact: rhv-devops

Comment 19 RHV bug bot 2018-01-12 14:41:05 UTC
INFO: Bug status (ON_QA) wasn't changed but the folowing should be fixed:

[Project 'ovirt-engine'/Component 'vdsm' mismatch]

For more info please contact: rhv-devops

Comment 20 Avihai 2018-01-16 14:25:03 UTC
Verified (not the web admin/rest portal changes) on 4.2.1.1-0.1.el7.
Customer scenario & no duplicate iscsi sessions were seen.

Comment 24 errata-xmlrpc 2018-05-15 17:45:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:1488

Comment 25 Franta Kust 2019-05-16 13:08:19 UTC
BZ<2>Jira Resync

Comment 26 Daniel Gur 2019-08-28 13:14:31 UTC
sync2jira

Comment 27 Daniel Gur 2019-08-28 13:19:33 UTC
sync2jira